-
Notifications
You must be signed in to change notification settings - Fork 21
Closed
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
Hi Thank you for updating gax-nodejs to 3.2.0
After release, i pulled repository and yarn install to install dependency & compile/build project.
but, i got type error after typescript compile
1) Is this a client library issue or a product issue?
this is a client library issue i think.
[Issue ScreenShot]
2) Did someone already solve this?
I think the problem may due to this commit. (removing "download" package from devDependencies
- googleapis/gax-nodejs@5898da6#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519)
After I add "download" to devDependencies, it solved.
"download": "^8.0.0",Environment details
- OS: MacOS Monteray 12.5
- Node.js version: 16.15.0
- npm version: 8.5.5
google-gaxversion: 3.2.0
Steps to reproduce
- local pull latest main
- yarn install it
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
