-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Labels
size: sPull request size is small.Pull request size is small.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
Currently, if you enable GOOGLE_SDK_NODE_LOGGING to get extra logging, both the instance request and the instance metadata are logged.
Unfortunately, the latter includes an access_token in it, which is rather dangerous to log.
I can imagine two solutions:
- Remove the access_token from the log, and maybe introduce another env var like
INCLUDE_ACCESS_TOKEN_IN_LOGif someone really wants it - Split the logger into two subloggers (request/response?) which would allow the user to configure which one they want with
GOOGLE_SDK_NODE_LOGGINGhttps://github.com/googleapis/gax-nodejs/tree/main/logging-utils#logging
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
size: sPull request size is small.Pull request size is small.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.