fix: (secretmanaer) readd legacy path templates by sofisl · Pull Request #5290 · googleapis/google-cloud-node

TypeError: Cannot read properties of undefined (reading 'render')
    at SecretManagerServiceClient.secretVersionPath (node_modules/@google-cloud/secret-manager/build/src/v1/secret_manager_service_client.js:1161:61)

And indeed, secretVersionPathTemplate does not exist in pathTemplates.

EDIT: Saw that this could be fixed by #5333.

fix: readd legacy path templates

c8bb4d4

sofisl requested review from a team and yoshi-approver as code owners April 29, 2024 20:13

gcf-owl-bot bot and others added 2 commits April 29, 2024 20:19

🦉 Updates from OwlBot post-processor

595008a

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update owlbot.py

8c2691d

alexander-fenster approved these changes Apr 29, 2024

View reviewed changes

sofisl changed the title ~~fix: readd legacy path templates~~ fix: (secretmanaer) readd legacy path templates Apr 30, 2024

sofisl and others added 23 commits April 29, 2024 22:38

Update secret_manager_service_client.ts

a70ff4e

🦉 Updates from OwlBot post-processor

2fafc38

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot post-processor

011120c

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update owlbot.py

b451056

🦉 Updates from OwlBot post-processor

fb47742

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

387b80a

…ogle-cloud-node into secretManagerFixes

🦉 Updates from OwlBot post-processor

d0f9904

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

65a892e

…ogle-cloud-node into secretManagerFixes

🦉 Updates from OwlBot post-processor

0520b03

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

a13ecd0

…ogle-cloud-node into secretManagerFixes

🦉 Updates from OwlBot post-processor

a2b78d7

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

6580dfe

…ogle-cloud-node into secretManagerFixes

🦉 Updates from OwlBot post-processor

e74c459

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

780e88e

…ogle-cloud-node into secretManagerFixes

🦉 Updates from OwlBot post-processor

eba82e4

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

b226113

…ogle-cloud-node into secretManagerFixes

🦉 Updates from OwlBot post-processor

135ffb7

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

bd1f5b1

…ogle-cloud-node into secretManagerFixes

🦉 Updates from OwlBot post-processor

a2ffac0

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

7baa97c

…ogle-cloud-node into secretManagerFixes

🦉 Updates from OwlBot post-processor

fd81e29

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

64808bd

…ogle-cloud-node into secretManagerFixes

🦉 Updates from OwlBot post-processor

851519a

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

gcf-owl-bot bot and others added 17 commits April 30, 2024 03:53

🦉 Updates from OwlBot post-processor

8d72fef

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot post-processor

9c3c1f3

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot post-processor

d11b8d5

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

chore: remove extra functions

564ff04

🦉 Updates from OwlBot post-processor

4046666

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot post-processor

52c24d2

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot post-processor

f078b02

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot post-processor

657ceb6

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

🦉 Updates from OwlBot post-processor

65adf9b

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Update owlbot.py

45b50c3

chore revert change to index

17c2b09

🦉 Updates from OwlBot post-processor

9286250

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

7d1eceb

…ogle-cloud-node into secretManagerFixes

Update owlbot.py

6c4c49d

Update owlbot.py

f1a5f8e

Update owlbot.py

304f77b

chore: update owlbot file

aeea9d3

sofisl added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 30, 2024

finally fix regex

e16436e

sofisl force-pushed the secretManagerFixes branch from f31f642 to e16436e Compare May 1, 2024 19:34

sofisl removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 1, 2024

sofisl and others added 5 commits May 1, 2024 15:37

Merge branch 'main' into secretManagerFixes

c332ca6

🦉 Updates from OwlBot post-processor

b16e8e1

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

10742c0

…ogle-cloud-node into secretManagerFixes

🦉 Updates from OwlBot post-processor

58c34dd

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Merge branch 'secretManagerFixes' of https://github.com/googleapis/go…

24c7b67

…ogle-cloud-node into secretManagerFixes

sofisl merged commit 5e14553 into main May 2, 2024

sofisl deleted the secretManagerFixes branch May 2, 2024 16:36

release-please bot mentioned this pull request May 2, 2024

chore: release main #5286

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: (secretmanaer) readd legacy path templates#5290

fix: (secretmanaer) readd legacy path templates#5290
sofisl merged 58 commits intomainfrom
secretManagerFixes

sofisl commented Apr 29, 2024 •

edited

Loading

Uh oh!

flovouin commented May 17, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sofisl commented Apr 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flovouin commented May 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sofisl commented Apr 29, 2024 •

edited

Loading

flovouin commented May 17, 2024 •

edited

Loading