Honour the timeout while making the request#3849
Closed
urjitbhatia wants to merge 1 commit intogoogleapis:mainfrom
Closed
Honour the timeout while making the request#3849urjitbhatia wants to merge 1 commit intogoogleapis:mainfrom
urjitbhatia wants to merge 1 commit intogoogleapis:mainfrom
Conversation
The customized request method here isn't forwarding the timeout param to the base request object. This fix will enable proper timeout settings
Contributor
|
Hi @urjitbhatia, please open an issue here first, as this code is autogenerated from the library I linked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The customized request method here isn't forwarding the timeout param to the base request object. This fix will enable proper timeout settings
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕