fix(bigquery): run npm run types in correct directory in owlbot#8061
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the owlbot.py script in the handwritten/bigquery directory to specify the current working directory when running the npm run types command. This ensures the command executes in the correct context. I have no feedback to provide as there are no review comments.
|
|
||
| # Regenerate Discovery types. | ||
| shell.run(('npm','run','types')) | ||
| shell.run(('npm', 'run', 'types'), cwd='handwritten/bigquery') |
There was a problem hiding this comment.
(question only) Does this only apply to bigquery lol? And was this a new problem after monorepo I guess?
There was a problem hiding this comment.
Yea I went through the other handwritten libraries. Firestore already specifies the directory when running commands. Storage and Spanner don't execute npm commands during the build.
BigQuery was the only one that had the run command without specifying the directory. And yes we haven't released BigQuery since the monorepo migration so it didn't surface earlier.
e57697f to
6bcaa1c
Compare
Fixes OwlBot failure by running the command in the component directory instead of the root.