feat: [control] generate bucket ops into storage control lib for nodejs #6874

gcf-owl-bot · 2025-11-08T00:03:01Z

Regenerate this pull request now.

PiperOrigin-RevId: 829559857

Source-Link: googleapis/googleapis@178dbf3

Source-Link: https://github.com/googleapis/googleapis-gen/commit/fd356677b796e25291818a6e3cd4b745a40b1a67
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLXN0b3JhZ2UtY29udHJvbC8uT3dsQm90LnlhbWwiLCJoIjoiZmQzNTY2NzdiNzk2ZTI1MjkxODE4YTZlM2NkNGI3NDVhNDBiMWE2NyJ9

dpebot · 2025-11-08T00:03:11Z

/gcbrun

snippet-bot · 2025-11-08T00:11:34Z

Here is the summary of changes.

You are about to add 6 region tags.

packages/google-storage-control/samples/generated/v2/storage.create_bucket.js:24, tag storage_v2_generated_Storage_CreateBucket_async
packages/google-storage-control/samples/generated/v2/storage.delete_bucket.js:24, tag storage_v2_generated_Storage_DeleteBucket_async
packages/google-storage-control/samples/generated/v2/storage.get_bucket.js:24, tag storage_v2_generated_Storage_GetBucket_async
packages/google-storage-control/samples/generated/v2/storage.list_buckets.js:24, tag storage_v2_generated_Storage_ListBuckets_async
packages/google-storage-control/samples/generated/v2/storage.lock_bucket_retention_policy.js:24, tag storage_v2_generated_Storage_LockBucketRetentionPolicy_async
packages/google-storage-control/samples/generated/v2/storage.update_bucket.js:24, tag storage_v2_generated_Storage_UpdateBucket_async

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

dpebot · 2025-11-08T00:11:46Z

/gcbrun

dpebot · 2025-11-10T22:33:38Z

/gcbrun

ddelgrosso1 · 2025-11-10T22:38:28Z

Actively working on some additional processing for this PR. Marking as Do Not Merge until I have added the necessary files / logic.

dpebot · 2025-11-11T18:14:16Z

/gcbrun

dpebot · 2025-11-14T19:31:25Z

/gcbrun

dpebot · 2025-11-14T19:32:20Z

/gcbrun

ddelgrosso1 · 2025-11-14T19:42:04Z

Updated the code to include "post processor". Running some additional tests before removing the do not merge tag.

dpebot · 2025-11-17T15:23:40Z

/gcbrun

packages/google-storage-control/src/storage_control_client.ts

packages/google-storage-control/src/v2/uber_storage_control_client.ts

packages/google-storage-control/src/storage_control_client.ts

packages/google-storage-control/src/v2/uber_storage_control_client.ts

packages/google-storage-control/src/util/uber_client_builder.ts

packages/google-storage-control/package.json

packages/google-storage-control/src/util/ast_utils.ts

packages/google-storage-control/src/util/proto_utils.ts

dpebot · 2025-11-18T16:11:07Z

/gcbrun

dpebot · 2025-11-18T17:35:47Z

/gcbrun

packages/google-storage-control/src/util/proto_utils.ts

dpebot · 2025-11-20T15:15:11Z

/gcbrun

dpebot · 2025-11-20T15:15:25Z

/gcbrun

sofisl · 2025-11-20T23:13:17Z

I don't think I have any real comments on the code - not familiar with modernizing a client. However, I'd be curious if we can add any tests to utils?

Basically, I'm thinking about what will inevitably happen: one day, someday, none of us will be responsible for any of these libraries, and something here is going to break, and inevitably someone will ask, who wrote this code? do we actually need it?

I don't think it's necessary to have tests, (especially since there's system tests, technically), but I'm just thinking about how we can future proof this. Another idea is just to have lots and lots of documentation!

packages/google-storage-control/src/storage_control_client.ts

packages/google-storage-control/test/storage_control_compatibility.ts

PiperOrigin-RevId: 829559857 Source-Link: googleapis/googleapis@178dbf3 Source-Link: googleapis/googleapis-gen@fd35667 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLXN0b3JhZ2UtY29udHJvbC8uT3dsQm90LnlhbWwiLCJoIjoiZmQzNTY2NzdiNzk2ZTI1MjkxODE4YTZlM2NkNGI3NDVhNDBiMWE2NyJ9

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

dpebot · 2025-12-03T19:09:48Z

/gcbrun

dpebot · 2025-12-03T19:21:05Z

/gcbrun

dpebot · 2025-12-03T19:39:34Z

/gcbrun

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

dpebot · 2025-12-03T19:51:29Z

/gcbrun

BenWhitehead

A few nits to hopefully simplify skimming and not needing to read a full function.

packages/google-storage-control/src/util/index_fix_utils.ts

packages/google-storage-control/src/util/proto_utils.ts

package.json

dpebot · 2025-12-15T15:25:39Z

/gcbrun

dpebot · 2025-12-15T15:26:24Z

/gcbrun

BenWhitehead

Thanks for the additional clarifying comments.

dpebot · 2025-12-15T19:08:54Z

/gcbrun

dpebot · 2025-12-15T19:09:31Z

/gcbrun

feywind

Re-approving after the nits.

gcf-owl-bot bot added the owl-bot-copy label Nov 8, 2025

gcf-owl-bot bot marked this pull request as ready for review November 8, 2025 00:11

gcf-owl-bot bot requested review from a team and yoshi-approver as code owners November 8, 2025 00:11

sofisl assigned ddelgrosso1 Nov 10, 2025

ddelgrosso1 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 10, 2025

ddelgrosso1 force-pushed the owl-bot-copy-packages-google-storage-control branch from e967b2f to 2649731 Compare November 14, 2025 19:31

ddelgrosso1 force-pushed the owl-bot-copy-packages-google-storage-control branch from 2649731 to 6d33537 Compare November 14, 2025 19:32

leahecole requested changes Nov 18, 2025

View reviewed changes

ddelgrosso1 force-pushed the owl-bot-copy-packages-google-storage-control branch from 234c6d2 to 71515ca Compare November 18, 2025 16:10

leahecole reviewed Nov 19, 2025

View reviewed changes

packages/google-storage-control/src/util/proto_utils.ts Show resolved Hide resolved

leahecole previously approved these changes Nov 20, 2025

View reviewed changes

danielduhh reviewed Nov 24, 2025

View reviewed changes

packages/google-storage-control/src/storage_control_client.ts Show resolved Hide resolved

packages/google-storage-control/src/storage_control_client.ts Show resolved Hide resolved

packages/google-storage-control/test/storage_control_compatibility.ts Show resolved Hide resolved

gcf-owl-bot bot added 2 commits December 3, 2025 18:25

🦉 Updates from OwlBot post-processor

9b51597

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

fix command

cf386be

ddelgrosso1 dismissed leahecole’s stale review via cf386be December 3, 2025 19:09

fix npx command alias

4e2fd60

install deps

67e6081

🦉 Updates from OwlBot post-processor

0170fbb

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

BenWhitehead reviewed Dec 3, 2025

View reviewed changes

packages/google-storage-control/src/util/index_fix_utils.ts Show resolved Hide resolved

packages/google-storage-control/src/util/index_fix_utils.ts Show resolved Hide resolved

packages/google-storage-control/src/util/proto_utils.ts Show resolved Hide resolved

leahecole previously approved these changes Dec 3, 2025

View reviewed changes

danielduhh approved these changes Dec 7, 2025

View reviewed changes

sofisl previously approved these changes Dec 11, 2025

View reviewed changes

sofisl reviewed Dec 11, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

ddelgrosso1 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 15, 2025

Merge branch 'main' into owl-bot-copy-packages-google-storage-control

9e1770a

address pr comments

8b2e025

ddelgrosso1 dismissed stale reviews from leahecole and sofisl via 8b2e025 December 15, 2025 15:26

BenWhitehead approved these changes Dec 15, 2025

View reviewed changes

move prettier to local package.json for storage-control

fcda5ee

Merge branch 'main' into owl-bot-copy-packages-google-storage-control

6b5487a

feywind approved these changes Dec 15, 2025

View reviewed changes

feywind merged commit 9dd2f04 into main Dec 15, 2025
11 checks passed

feywind deleted the owl-bot-copy-packages-google-storage-control branch December 15, 2025 20:24

release-please bot mentioned this pull request Dec 15, 2025

chore: release main #6930

Merged

feat: [control] generate bucket ops into storage control lib for nodejs #6874

feat: [control] generate bucket ops into storage control lib for nodejs #6874

Uh oh!

Conversation

gcf-owl-bot bot commented Nov 8, 2025

Uh oh!

dpebot commented Nov 8, 2025

Uh oh!

snippet-bot bot commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dpebot commented Nov 8, 2025

Uh oh!

dpebot commented Nov 10, 2025

Uh oh!

ddelgrosso1 commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dpebot commented Nov 11, 2025

Uh oh!

dpebot commented Nov 14, 2025

Uh oh!

dpebot commented Nov 14, 2025

Uh oh!

ddelgrosso1 commented Nov 14, 2025

Uh oh!

dpebot commented Nov 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dpebot commented Nov 18, 2025

Uh oh!

dpebot commented Nov 18, 2025

Uh oh!

Uh oh!

dpebot commented Nov 20, 2025

Uh oh!

dpebot commented Nov 20, 2025

Uh oh!

sofisl commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dpebot commented Dec 3, 2025

Uh oh!

dpebot commented Dec 3, 2025

Uh oh!

dpebot commented Dec 3, 2025

Uh oh!

dpebot commented Dec 3, 2025

Uh oh!

BenWhitehead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dpebot commented Dec 15, 2025

Uh oh!

dpebot commented Dec 15, 2025

Uh oh!

BenWhitehead left a comment

Choose a reason for hiding this comment

Uh oh!

dpebot commented Dec 15, 2025

Uh oh!

dpebot commented Dec 15, 2025

Uh oh!

feywind left a comment

Choose a reason for hiding this comment

snippet-bot bot commented Nov 8, 2025 •

edited

Loading

ddelgrosso1 commented Nov 10, 2025 •

edited

Loading

sofisl commented Nov 20, 2025 •

edited

Loading