Conversation
suztomo
commented
Feb 23, 2023
java-bigqueryconnection/.OwlBot.yaml
Outdated
Comment on lines
-24
to
-25
| - "/java-bigqueryconnection/proto-google-cloud-bigqueryconnection-v1/src/main/java/com/google/cloud/bigquery/connection/v1/ConnectionProto.java" | ||
| - "/java-bigqueryconnection/proto-google-cloud-bigqueryconnection-v1/src/main/java/com/google/cloud/bigquery/connection/ConnectionProto.java" |
Member
Author
There was a problem hiding this comment.
Strange. I don't intend to modify this.
Removing release-non-google-oss-sonatype profile in favor of the command line parameters
2de3644 to
992016b
Compare
suztomo
commented
Feb 23, 2023
| setup_environment_secrets | ||
| create_settings_xml_file "settings.xml" | ||
|
|
||
| echo "Deploying artifacts to staging repositories" |
Member
Author
There was a problem hiding this comment.
No functionality change in this shell script. Just changing variable name and comments.
suztomo
commented
Feb 23, 2023
|
|
||
| env_vars: { | ||
| key: "TRAMPOLINE_BUILD_FILE" | ||
| value: "github/google-cloud-java/.kokoro/release/stage-non-google-oss-sonatype.sh" |
Member
Author
There was a problem hiding this comment.
Memo: This file is copy from stage.cfg except this shell script.
JoeWang1127
approved these changes
Feb 23, 2023
| echo "Deploying non-Cloud artifacts to staging repositories in oss.sonatype.org" | ||
|
|
||
| # Lists modules for Google Maps artifacts, including their submodules. | ||
| includedMapsModule=$(find java-maps-* -name 'pom.xml' \ |
Contributor
There was a problem hiding this comment.
Should we change includedMapsModule to nonCloudModules? Maybe there will be artifacts similar to this one.
suztomo
commented
Feb 24, 2023
| env_vars: { | ||
| key: "TRAMPOLINE_BUILD_FILE" | ||
| value: "github/google-cloud-java/.kokoro/release/stage.sh" | ||
| value: "github/google-cloud-java/.kokoro/release/stage_google_oss_sonatype_org.sh" |
Member
Author
There was a problem hiding this comment.
@ddixit14 Can you review this change? Is this looking good to you?
Contributor
There was a problem hiding this comment.
Yes, I think it makes more sense than having something like stage_maps.sh because we might get more artifacts which have the same host.
ddixit14
approved these changes
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9045. This is a release job for Maps libraries. Currently we have 2 of them: java-maps-addressvalidation and java-maps-routing.
Introducing stage-non-google-oss-sonatype job, which I'll setup a child job of "stage" as below:
Renaming the group ID of the Maps artifacts so that they can be published to oss.sonatype.org together (See Setup a job for java-maps artifacts release #9045 for the background)
Would OwlBot Java Postprocessor override the group ID? => No, OwlBot post processor didn't revert the group ID change. Good.