Skip to content

declare BigQuery GA #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pongad merged 2 commits into from
Mar 1, 2018
Merged

declare BigQuery GA #2982

pongad merged 2 commits into from
Mar 1, 2018

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented Mar 1, 2018 •
edited
Loading

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2018
garrettjonesgoogle
garrettjonesgoogle reviewed Mar 1, 2018
View reviewed changes
google-cloud-bigquery/README.md Outdated
If you are using SBT, add this to your dependencies
```Scala
libraryDependencies += "com.google.cloud" % "google-cloud-bigquery" % "0.37.0-beta"
libraryDependencies += "com.google.cloud" % "google-cloud-bigquery" % "1.19.0"

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tswast
Copy link
Contributor

tswast commented Mar 1, 2018

Yay!

+1 to Garrett's suggestion to wait to update the readme until after the packages are published.

@pongad
Copy link
Contributor Author

pongad commented Mar 1, 2018

@garrettjonesgoogle PTAL

garrettjonesgoogle
garrettjonesgoogle approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pongad pongad merged commit 07fd013 into googleapis:master Mar 1, 2018
@pongad pongad deleted the bigquery-ga branch March 1, 2018 23:08
@tswast
Copy link
Contributor

tswast commented Mar 6, 2018

Was this packaged up? Looks like we're still missing the README update if so.

@garrettjonesgoogle
Copy link
Member

garrettjonesgoogle commented Mar 6, 2018

Yes it's packaged & released now - now we just need to update the READMEs.

@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Mar 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast Awaiting requested review from tswast

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pongad @tswast @garrettjonesgoogle @googlebot