CloudStorageReadChannel: more detailed error messages when retries/reopens are exhausted

droazen · droazen · commit fb22ea76e2de · 2017-07-07T14:21:04.000-04:00
Include the maxChannelReopens/maxRetries in the exception messages thrown
when reopens/retries are exhausted in CloudStorageReadChannel
diff --git a/google-cloud-contrib/google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageReadChannel.java b/google-cloud-contrib/google-cloud-nio/src/main/java/com/google/cloud/storage/contrib/nio/CloudStorageReadChannel.java
@@ -120,7 +120,7 @@ public int read(ByteBuffer dst) throws IOException {
             // but here at this higher level we can retry them.
             reopens++;
             if (reopens > maxChannelReopens) {
-              throw new StorageException(exs.getCode(), "All reopens failed", exs);
+              throw new StorageException(exs.getCode(), "All " + maxChannelReopens + " reopens failed", exs);
             }
             sleepForAttempt(reopens);
             innerOpen();
@@ -134,7 +134,7 @@ public int read(ByteBuffer dst) throws IOException {
               // "While in principle you should be able to retry, we already did that
               // for you a few times and it still didn't work so we wouldn't recommend
               // further retries."
-              throw new StorageException(exs.getCode(), "All retries failed", exs);
+              throw new StorageException(exs.getCode(), "All " + maxRetries + " retries failed", exs);
             }
             sleepForAttempt(retries);
             continue;
