Skip to content

Commit 16630e4

Browse files
committed
don't use AutoValue
This commit reverts most of the changes to (Publisher|Subscriber)Stats. For some reason, AutoValue doesn't work in this repository.
1 parent 087427c commit 16630e4

2 files changed

Lines changed: 74 additions & 20 deletions

File tree

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/PublisherStats.java

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,44 @@
1616

1717
package com.google.cloud.pubsub;
1818

19-
import com.google.auto.value.AutoValue;
19+
import javax.annotation.concurrent.Immutable;
2020

2121
/**
2222
* A snapshot of the publisher statistics at the time they were requested from the {@link
2323
* Publisher}.
2424
*/
2525
//TODO: Finish implementation.
26-
@AutoValue
27-
public abstract class PublisherStats {
26+
@Immutable
27+
public class PublisherStats {
28+
private final long sentMessages;
29+
private final long ackedMessages;
30+
private final long failedMessages;
31+
private final long pendingMessages;
32+
33+
PublisherStats(long sentMessages, long ackedMessages, long failedMessages, long pendingMessages) {
34+
this.sentMessages = sentMessages;
35+
this.ackedMessages = ackedMessages;
36+
this.failedMessages = failedMessages;
37+
this.pendingMessages = pendingMessages;
38+
}
39+
2840
/** Number of successfully published messages. */
29-
public abstract long getAckedMessages();
41+
public long getAckedMessages() {
42+
return ackedMessages;
43+
}
3044

3145
/** Number of messages that failed to publish. */
32-
public abstract long getFailedMessages();
46+
public long getFailedMessages() {
47+
return failedMessages;
48+
}
3349

3450
/** Number of messages pending to publish, includes message in-flight. */
35-
public abstract long getPendingMessages();
51+
public long getPendingMessages() {
52+
return pendingMessages;
53+
}
3654

3755
/** Total messages sent, equal to pending + acked + failed messages. */
38-
public abstract long getSentMessages();
56+
public long getSentMessages() {
57+
return sentMessages;
58+
}
3959
}

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/SubscriberStats.java

Lines changed: 47 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,33 +16,67 @@
1616

1717
package com.google.cloud.pubsub;
1818

19-
import com.google.auto.value.AutoValue;
19+
import javax.annotation.concurrent.Immutable;
2020

2121
/**
2222
* A snapshot of the subscriber statistics at the time they were requested from the {@link
2323
* Subscriber}.
2424
*/
2525
//TODO: Finish implementation.
26-
@AutoValue
27-
public abstract class SubscriberStats {
28-
@AutoValue
29-
public static abstract class Stats {}
26+
@Immutable
27+
public class SubscriberStats {
28+
@Immutable
29+
public static class Stats {}
3030

31-
/** Number of received messages. */
32-
public abstract long totalReceivedMessages();
31+
private final long totalReceivedMessages;
32+
private final long totalAckedMessages;
33+
private final Stats endToEndLatency;
34+
private final Stats ackLatency;
35+
private final long numberOfAutoExtendedAckDeadlines;
36+
37+
SubscriberStats() {
38+
this.totalReceivedMessages = 0;
39+
this.totalAckedMessages = 0;
40+
this.numberOfAutoExtendedAckDeadlines = 0;
41+
this.endToEndLatency = null;
42+
this.ackLatency = null;
43+
}
44+
45+
/** Number of successfully published messages. */
46+
public long getReceivedMessages() {
47+
return totalReceivedMessages;
48+
}
3349

3450
/** Number of successfully published messages. */
35-
public abstract long totalAckedMessages();
51+
public long getAckedMessages() {
52+
return totalAckedMessages;
53+
}
54+
55+
/** Number of received messages. */
56+
public long getTotalReceivedMessages() {
57+
return totalReceivedMessages;
58+
}
59+
60+
/** Number messages acked. */
61+
public long getTotalAckedMessages() {
62+
return totalAckedMessages;
63+
}
3664

3765
/** End to end latency. */
38-
public abstract Stats endToEndLatency();
66+
public Stats getEndToEndLatency() {
67+
return endToEndLatency;
68+
}
3969

4070
/**
41-
* Acknowledgement latency. The duration between the message being received and
42-
* being acknowledged or rejected.
71+
* Acknowledgement latency; time in between the message has been received and then acknowledged or
72+
* rejected.
4373
*/
44-
public abstract Stats ackLatency();
74+
public Stats getAckLatency() {
75+
return ackLatency;
76+
}
4577

4678
/** Number of messages for which we have auto extended its acknowledgement deadline. */
47-
public abstract long numberOfAutoExtendedAckDeadlines();
79+
public long getNumberOfAutoExtendedAckDeadlines() {
80+
return numberOfAutoExtendedAckDeadlines;
81+
}
4882
}

0 commit comments

Comments
 (0)