Skip to content

test(bigtable): Use existing cluster for integration tests#9509

Merged
bhshkh merged 4 commits intogoogleapis:mainfrom
bhshkh:test/cbt-integration-tests-2
Mar 13, 2024
Merged

test(bigtable): Use existing cluster for integration tests#9509
bhshkh merged 4 commits intogoogleapis:mainfrom
bhshkh:test/cbt-integration-tests-2

Conversation

@bhshkh
Copy link
Copy Markdown
Contributor

@bhshkh bhshkh commented Mar 5, 2024

Issue: Creating and deleting cluster while running integration test is causing multiple test failures.

#9310

#9257

#9420

#9366

#9258

#9392

#9365

One of the common errors is :

Could not modify schema of projects/dulcet-port-762/instances/gc-bt-it-instance/tables/cbt-test-1707036071564201376-11, due to concurrent modifications. This could mean another change to this tables schema, or a change to the replication topology (adding/removing a cluster)

Fix: Use existing cluster for integration tests

@gkevinzheng
Copy link
Copy Markdown
Contributor

LGTM

Copy link
Copy Markdown

@danieljbruce danieljbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess adding the second cluster is a one time setup?

@bhshkh
Copy link
Copy Markdown
Contributor Author

bhshkh commented Mar 13, 2024

LGTM. I guess adding the second cluster is a one time setup?

Yes

@bhshkh bhshkh enabled auto-merge (squash) March 13, 2024 14:21
@bhshkh bhshkh merged commit e881afd into googleapis:main Mar 13, 2024
@bhshkh bhshkh deleted the test/cbt-integration-tests-2 branch March 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API. size: m Pull request size is medium.

Projects

None yet

4 participants