Skip to content

test(bigtable): Retry deleting cluster#9098

Merged
bhshkh merged 5 commits intogoogleapis:mainfrom
bhshkh:issue/bt-9065
Dec 11, 2023
Merged

test(bigtable): Retry deleting cluster#9098
bhshkh merged 5 commits intogoogleapis:mainfrom
bhshkh:issue/bt-9065

Conversation

@bhshkh
Copy link
Copy Markdown
Contributor

@bhshkh bhshkh commented Dec 7, 2023

Issue: AdminCopyBackup test fails with error:

=== RUN   TestIntegration_AdminCopyBackup
    integration_test.go:3091: CreateCluster: rpc error: code = FailedPrecondition desc = Cannot create multiple clusters in the same zone.
--- FAIL: TestIntegration_AdminCopyBackup (10.29s)

Cause: Sometimes, cluster created in previous run is not getting deleted
Fix: Retry deleting the cluster

This PR also contains the change to run tests requiring instance creation only if 'run-create-instance-tests' flag is set

@bhshkh bhshkh requested review from a team December 7, 2023 20:49
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the Bigtable API. labels Dec 7, 2023
@bhshkh bhshkh requested a review from gkevinzheng December 7, 2023 20:50
@bhshkh bhshkh linked an issue Dec 7, 2023 that may be closed by this pull request
bigtable: TestIntegration_AdminCopyBackup failed #9065
Closed
@kolea2 kolea2 changed the title fix(bigtable): Retry deleting cluster test(bigtable): Retry deleting cluster Dec 11, 2023
@bhshkh bhshkh enabled auto-merge (squash) December 11, 2023 19:08
@bhshkh bhshkh disabled auto-merge December 11, 2023 19:31
@bhshkh bhshkh enabled auto-merge (squash) December 11, 2023 19:37
@bhshkh bhshkh disabled auto-merge December 11, 2023 19:37
@bhshkh bhshkh enabled auto-merge (squash) December 11, 2023 19:37
@bhshkh bhshkh disabled auto-merge December 11, 2023 19:37
@bhshkh bhshkh enabled auto-merge (squash) December 11, 2023 19:38
@bhshkh bhshkh merged commit ee8dd00 into googleapis:main Dec 11, 2023
@bhshkh bhshkh deleted the issue/bt-9065 branch December 11, 2023 19:55
@bhshkh bhshkh linked an issue Dec 11, 2023 that may be closed by this pull request
bigtable: TestIntegration_Admin failed #9067
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

+1 more reviewer

@kolea2 kolea2 kolea2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigtable: TestIntegration_Admin failed bigtable: TestIntegration_AdminCopyBackup failed

3 participants

@bhshkh @kolea2 @gkevinzheng