Revert "fix(storage): SignedURL v4 allows headers with colons in value"#7592
Merged
gcf-merge-on-green[bot] merged 1 commit intomainfrom Mar 20, 2023
Merged
Revert "fix(storage): SignedURL v4 allows headers with colons in value"#7592gcf-merge-on-green[bot] merged 1 commit intomainfrom
gcf-merge-on-green[bot] merged 1 commit intomainfrom
Conversation
codyoss
approved these changes
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes a build failure in Go 1.17 because
strings.Cutwas not added until Go 1.18. Need to investigate why the presubmit did not catch this.Reverts #7543
Fixes #7588