chore: librarian generate pull request: 20260128T080408Z#13735
Conversation
Summary of ChangesHello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated client library generation, incorporating a range of API updates across Google Cloud services. It primarily introduces new features and configurations for Retail, Container, and Network Management APIs, alongside various documentation improvements and minor fixes. The changes reflect recent advancements in the underlying protocol buffer definitions, ensuring the client libraries remain up-to-date with the latest service capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, generated by the Librarian CLI, introduces several updates across multiple client libraries, primarily from new proto definitions. The changes include adding new fields and messages for services like Retail, Container, and Network Management, as well as numerous documentation improvements for clarity and consistency in Document AI and other services. The review identified one potential issue in the Document AI API where a field's type appears to be inconsistent with its name and documentation. Otherwise, the changes look correct as part of an automated generation process.
| // Optional. The number of tokens to group together when evaluating | ||
| // semantic similarity. THIS FIELD IS NOT YET USED. | ||
| // semantic similarity. | ||
| // **Note:** This field is not yet used. | ||
| SemanticChunkingGroupSize bool `protobuf:"varint,3,opt,name=semantic_chunking_group_size,json=semanticChunkingGroupSize,proto3" json:"semantic_chunking_group_size,omitempty"` |
There was a problem hiding this comment.
The field SemanticChunkingGroupSize is defined as a bool, but its name and documentation ("The number of tokens to group together...") indicate it should be a numeric type like int32. This inconsistency in the API definition can cause confusion. Please consider changing the type in the source proto file to a numeric type to match its semantic meaning.
PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.
BEGIN_COMMIT
BEGIN_NESTED_COMMIT
feat: add a model_scores field in SearchResponse.results to expose model quality signals
PiperOrigin-RevId: 861314205
Library-IDs: retail
Source-link: googleapis/googleapis@6517e3ba
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add a user_attributes field in SearchRequest that can be used for personalization
PiperOrigin-RevId: 861314205
Library-IDs: retail
Source-link: googleapis/googleapis@6517e3ba
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add SwapConfig to enable and configure swap memory for node pools
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
tpu_ipv4_cidr_blockin message.google.container.v1.Clusteris changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add DisruptionEvent to provide details on node disruption events
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add GPUDirectConfig to configure GPU Direct for node pools
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add consolidation_delay to configure Cluster Autoscaler node consolidation delay
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
sysctlsin message.google.container.v1.LinuxNodeConfigis changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
subnetworkin message.google.container.v1.NodeNetworkConfigis changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
services_ipv4_cidrin message.google.container.v1.Clusteris changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add ManagedOpenTelemetryConfig to Cluster to manage the OpenTelemetry pipeline
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add AutopilotGeneralProfile to ClusterAutoscaling to configure Autopilot profiles
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
node_ipv4_cidr_blockin message.google.container.v1.IPAllocationPolicyis changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
tpu_ipv4_cidr_blockin message.google.container.v1.IPAllocationPolicyis changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
recurrencein message.google.container.v1.RecurringTimeWindowis changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add SHORT_LIVED as a NodePoolUpdateStrategy
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
cluster_ipv4_cidrin message.google.container.v1.Clusteris changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add RegistryHostConfig to ContainerdConfig for containerd registry host configuration
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add SliceControllerConfig to AddonsConfig to manage the Slice Controller addon
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
cluster_ipv4_cidr_blockin message.google.container.v1.IPAllocationPolicyis changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
services_ipv4_cidr_blockin message.google.container.v1.IPAllocationPolicyis changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add NodeDrainConfig to NodePool to configure node draining behavior
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Add DRAINING status to AdditionalIPRangesConfig for subnet draining
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: Allow specifying subnetwork in NodeNetworkConfig during node pool creation
PiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: A comment for field
gcp_secret_manager_certificate_configin message.google.container.v1.ContainerdConfigis changedPiperOrigin-RevId: 859731311
Library-IDs: container
Source-link: googleapis/googleapis@928703e0
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add fields and messages for GKE Pods and IP masquerading
PiperOrigin-RevId: 859595508
Library-IDs: networkmanagement
Source-link: googleapis/googleapis@3343c4ed
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Regenerated REST and RPC Document AI documentation to include missing changes from September 2024 to November 2025
PiperOrigin-RevId: 859310712
Library-IDs: documentai
Source-link: googleapis/googleapis@64f78809
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Fixed language issues in multiple message field descriptions
PiperOrigin-RevId: 859310712
Library-IDs: documentai
Source-link: googleapis/googleapis@64f78809
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
docs: Correct typo in comment for field
quota_idPiperOrigin-RevId: 859139909
Library-IDs: cloudquotas
Source-link: googleapis/googleapis@6b36371f
END_NESTED_COMMIT
END_COMMIT
This pull request is generated with proto changes between
googleapis/googleapis@2ac88973
(exclusive) and
googleapis/googleapis@6517e3ba
(inclusive).
Librarian Version: v0.0.0-20251218164811-cd2252e38d0a
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:01189c9771ac4150742aed38eb52e19a008018889066002742034b7f82db070f