Skip to content

test(bigtable/internal): Add missing arg in NewBigtableChannelPool test#13559

Merged
bhshkh merged 2 commits intogoogleapis:mainfrom
bhshkh:test/cbt-internal-build-13552
Jan 8, 2026
Merged

test(bigtable/internal): Add missing arg in NewBigtableChannelPool test#13559
bhshkh merged 2 commits intogoogleapis:mainfrom
bhshkh:test/cbt-internal-build-13552

Conversation

@bhshkh
Copy link
Copy Markdown
Contributor

@bhshkh bhshkh commented Jan 8, 2026 •
edited
Loading

Fixes: #13552

@bhshkh bhshkh requested review from a team January 8, 2026 16:46
@bhshkh bhshkh requested a review from a team as a code owner January 8, 2026 16:46
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jan 8, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Jan 8, 2026

Summary of Changes

Hello @bhshkh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a test failure by providing a missing argument to the NewBigtableChannelPool constructor within a specific test case. The correction ensures that the test for connection pool removal behaves as intended, aligning the test's invocation with the updated signature of the NewBigtableChannelPool function.

Highlights

  • Test Fix: Corrected a test case in bigtable/internal/transport/connpool_test.go to properly invoke NewBigtableChannelPool.
  • Missing Argument: Added the time.Now() argument to the NewBigtableChannelPool constructor call within the TestRemoveConnections function.
  • Issue Resolution: This change addresses and fixes issue bigtable/internal/transport: [build failed] failed #13552.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 8, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a test by adding a missing argument to the NewBigtableChannelPool function call. My review suggests an improvement to enhance test determinism by replacing time.Now() with a fixed timestamp. This is a good practice to avoid potential flakiness in tests.

@bhshkh @gemini-code-assist
Update bigtable/internal/transport/connpool_test.go
bb67bfd 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@bhshkh bhshkh enabled auto-merge (squash) January 8, 2026 16:49
@bhshkh bhshkh merged commit 31f17fc into googleapis:main Jan 8, 2026
10 of 12 checks passed
@bhshkh bhshkh deleted the test/cbt-internal-build-13552 branch January 8, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shollyman shollyman shollyman approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigtable/internal/transport: [build failed] failed

2 participants

@bhshkh @shollyman