Skip to content

chore: librarian generate pull request: 20251028T070629Z #13244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
quartzmo merged 1 commit into from
Oct 28, 2025
Merged

chore: librarian generate pull request: 20251028T070629Z #13244

quartzmo merged 1 commit into from
Oct 28, 2025

Conversation

@cloud-sdk-librarian-robot
Copy link
Collaborator

@cloud-sdk-librarian-robot cloud-sdk-librarian-robot commented Oct 28, 2025

BEGIN_COMMIT_OVERRIDE

BEGIN_NESTED_COMMIT
feat: A new field remote_peering_network_type is added to message google.cloud.edgenetwork.v1.Interconnect

PiperOrigin-RevId: 824727309
Library-IDs: edgenetwork
Source-link: googleapis/googleapis@b1a9eefc
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: A new field peering_type is added to message google.cloud.edgenetwork.v1.InterconnectAttachment

PiperOrigin-RevId: 824727309
Library-IDs: edgenetwork
Source-link: googleapis/googleapis@b1a9eefc
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: updating enableDirectBigtableAccess field name in FeatureOnlineStore`

PiperOrigin-RevId: 824609499
Library-IDs: aiplatform
Source-link: googleapis/googleapis@a2e6e8dd
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: updating bigtable_metadata field name in FeatureView

PiperOrigin-RevId: 824609499
Library-IDs: aiplatform
Source-link: googleapis/googleapis@a2e6e8dd
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: updating bigtable_metadata field name in FeatureOnlineStore

PiperOrigin-RevId: 824609499
Library-IDs: aiplatform
Source-link: googleapis/googleapis@a2e6e8dd
END_NESTED_COMMIT

END_COMMIT_OVERRIDE

This pull request is generated with proto changes between
googleapis/googleapis@e8365a7f
(exclusive) and
googleapis/googleapis@b1a9eefc
(inclusive).

Librarian Version: v0.0.0-20251022181450-0ee9437f0ec3
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:496591304b0d24ab57ea5f2c8a7870921713edab7f6fd002c5b2e78a8d6de396

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Oct 28, 2025

Summary of Changes

Hello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates recent updates from the upstream Google APIs repository into the Go client libraries. The primary changes include the introduction of new fields in the Edge Network API to support remote peering network types and a renumbering of existing fields in the AI Platform API's Feature Online Store and Feature View messages. These updates ensure the client libraries remain current with the latest API definitions.

Highlights

  • Edge Network API Enhancements: New fields remote_peering_network_type and peering_type have been added to the Interconnect and InterconnectAttachment messages, respectively, within the google.cloud.edgenetwork.v1 API. These fields define the remote peering destination type, which is required when peering separation is enabled.
  • AI Platform Field Renumbering: The protobuf field numbers for enableDirectBigtableAccess and bigtable_metadata within the FeatureOnlineStore message, and bigtable_metadata within the FeatureView message, have been updated across both v1 and v1beta1 AI Platform APIs. This is a refactoring change to ensure correct field serialization.
  • Library State Update: The internal state file (.librarian/state.yaml) has been updated to reflect the latest generated commits for the aiplatform and edgenetwork libraries, ensuring synchronization with upstream Google API definitions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 28, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request applies automated updates from upstream API definitions. While the changes for edgenetwork are non-breaking features, the updates for aiplatform introduce critical breaking changes by renumbering Protobuf fields in the v1 and v1beta1 APIs. Changing field tags breaks wire compatibility and can cause issues for existing clients. This is particularly critical for a stable v1 API and should be accompanied by a major version increase.

This was referenced Oct 28, 2025
Closed
Closed
@parthea parthea mentioned this pull request Oct 28, 2025
Closed
@quartzmo quartzmo merged commit 89b5ea2 into main Oct 28, 2025
11 checks passed
@quartzmo quartzmo deleted the librarian-20251028T070629Z branch October 28, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jskeet jskeet jskeet approved these changes

@quartzmo quartzmo quartzmo approved these changes

@parthea parthea parthea approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cloud-sdk-librarian-robot @jskeet @quartzmo @parthea