Skip to content

feat(spanner): add otel semconv sql statement#12631

Closed
yordis wants to merge 3 commits intogoogleapis:mainfrom
fanatics-live:yordis/add-otel-sql-statement
Closed

feat(spanner): add otel semconv sql statement#12631
yordis wants to merge 3 commits intogoogleapis:mainfrom
fanatics-live:yordis/add-otel-sql-statement

Conversation

@yordis
Copy link
Copy Markdown

@yordis yordis commented Aug 1, 2025

No description provided.

@yordis yordis requested review from a team August 1, 2025 05:47
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 1, 2025
@yordis
Copy link
Copy Markdown
Author

yordis commented Aug 1, 2025

@rahul2393 could you help me with this one?

@rahul2393
Copy link
Copy Markdown
Contributor

I created PR with more attributes #11652

@rahul2393
Copy link
Copy Markdown
Contributor

@yordis you can apply the change in your GORM application by running this

go mod edit -replace cloud.google.com/go/spanner=github.com/googleapis/google-cloud-go/spanner@add-gcp-attribute-traces
go mod tidy
go mod download

@yordis
Copy link
Copy Markdown
Author

yordis commented Aug 1, 2025

@rahul2393 I already tested this in prod, but we had to rollback due to the streaming issue

fanatics-live@4bb558f

Screenshot 2025-08-01 at 6 42 48 PM

@rahul2393
Copy link
Copy Markdown
Contributor

Ok the context of this PR was to add sql statement in OTEL traces right?
What I am suggesting is I created another PR #11652 to not just add sql statement but other attributes which will help in debugging.

@yordis
Copy link
Copy Markdown
Author

yordis commented Aug 1, 2025

Ok the context of this PR was to add sql statement in OTEL traces right?

Correct

What I am suggesting is I created another PR #11652 to not just add sql statement but other attributes which will help in debugging.

I am not disagreeing here, but taking this PR reduce the blast radious, to me, whatever makes it to production ASAP; since we are blind right now. I rather have something, than nothing

@rahul2393
Copy link
Copy Markdown
Contributor

I have asked my team to review my PR since anyways we were planning to merge that for the long time.
Thanks
cc: @olavloite

@rahul2393
Copy link
Copy Markdown
Contributor

Closing this in favor of #11652

@rahul2393 rahul2393 closed this Aug 3, 2025
@yordis yordis deleted the yordis/add-otel-sql-statement branch August 3, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants