fix(spanner): inject "x-goog-spanner-request-id" into outgoing client context#11544
Merged
olavloite merged 2 commits intogoogleapis:mainfrom Feb 2, 2025
Merged
Conversation
rahul2393
reviewed
Jan 31, 2025
rahul2393
reviewed
Jan 31, 2025
281d102 to
acee589
Compare
acee589 to
bfa4afc
Compare
… context Injects metadata derived from the associated gax.CallOptions that were correctly being generated and tested, but accidentally not injected into the outgoing context. Fixes googleapis#11543
bfa4afc to
857012c
Compare
olavloite
approved these changes
Feb 2, 2025
Contributor
olavloite
left a comment
There was a problem hiding this comment.
Approving this to ensure progress. But can we add a test in a follow-up PR that fails without this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Injects metadata derived from the associated gax.CallOptions that were correctly being generated and tested, but accidentally not injected into the outgoing context.
Fixes #11543