test(spanner): skip/remove oc span related tests#11260
Merged
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom Dec 10, 2024
Merged
test(spanner): skip/remove oc span related tests#11260gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
gcf-merge-on-green[bot] merged 2 commits intogoogleapis:mainfrom
Conversation
I removed the obvious open census tests that were failing in googleapis#11257. Some others it was not clear to me if these functions should be instrumented with OT or not, so I skipped them for now and will let the spanner team decide what to do with those tests. Related: googleapis#11230
quartzmo
approved these changes
Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the obvious open census tests that were failing in #11257. Some others it was not clear to me if these functions should be instrumented with OT or not, so I skipped them for now and will let the spanner team decide what to do with those tests.
Related: #11230