fix(datastore): remove namespace from Key.String() (#10684)#10823
Merged
bhshkh merged 3 commits intogoogleapis:mainfrom Sep 5, 2024
Merged
fix(datastore): remove namespace from Key.String() (#10684)#10823bhshkh merged 3 commits intogoogleapis:mainfrom
bhshkh merged 3 commits intogoogleapis:mainfrom
Conversation
Datastore namespaces may be sensitive, and it's best not to emit them. Provide a `datastore.Key.StringWithNamespace()` as an alternative, and use this version internally, which preserves the fix from googleapis#7829.
Contributor
Author
…#10684) fix(datastore): remove namespace from Key.String() Fixes googleapis#10684. Datastore namespaces may be sensitive, and it's best not to emit them. Restores the behavior of `Key.String` prior to googleapis#8363, but maintains the fix for googleapis#7829 by providing an internal implementation that does provide the namespace.
bhshkh
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Datastore namespaces may be sensitive, and it's best not to emit them. See #10684.
Provide a
datastore.Key.StringWithNamespace()as an alternative, and use this version internally, which preserves the fix from #7829.