Skip to content

perf: avoid unnecessary fmt.Errorf#10752

Open
egonelbre wants to merge 17 commits intogoogleapis:mainfrom
egonelbre:fmterrorf
Open

perf: avoid unnecessary fmt.Errorf#10752
egonelbre wants to merge 17 commits intogoogleapis:mainfrom
egonelbre:fmterrorf

Conversation

@egonelbre
Copy link
Copy Markdown
Contributor

Fixes #9749

Automatically fixed with:

gofmt -w -r "fmt.Errorf(s) -> errors.New(s)" .
goimports -w .

Spanner related changes are in #10736

@egonelbre egonelbre requested review from a team August 23, 2024 11:39
@egonelbre egonelbre requested review from a team, gkevinzheng and mrfaizal August 23, 2024 11:39
bhshkh
bhshkh previously approved these changes Aug 23, 2024
tritone
tritone previously approved these changes Sep 5, 2024
Copy link
Copy Markdown
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage changes are fine. @codyoss wanna go ahead and merge this?

@egonelbre egonelbre dismissed stale reviews from tritone and bhshkh via 177427f June 5, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

perf: fmt.Errorf used instead of errors.New

3 participants