Skip to content

test(bigtable): Retry create column family#10487

Merged
bhshkh merged 6 commits intogoogleapis:mainfrom
bhshkh:test/cbt-flaky
Jul 8, 2024
Merged

test(bigtable): Retry create column family#10487
bhshkh merged 6 commits intogoogleapis:mainfrom
bhshkh:test/cbt-flaky

Conversation

@bhshkh
Copy link
Copy Markdown
Contributor

@bhshkh bhshkh commented Jul 2, 2024 •
edited
Loading

Fixes: #9392
Fixes: #9258

Before fix:

=== RUN   TestIntegration_ArbitraryTimestamps
    integration_test.go:3525: Running test against production
    integration_test.go:534: Creating column family: rpc error: code = Internal desc = Internal error encountered.
    integration_test.go:3570: DeleteTable got error rpc error: code = Internal desc = Internal error encountered.
--- FAIL: TestIntegration_ArbitraryTimestamps (106.98s)

This usually happens when zone / location is temporarily unavailable.
This PR adds retries for create column family

After fix:

Note: when using prod, you must first create an instance:
cbt createinstance instance01 instance01 instance01-c1 us-central1-b 1 SSD
=== RUN   TestIntegration_ArbitraryTimestamps
    integration_test.go:4125: Running test against production
--- PASS: TestIntegration_ArbitraryTimestamps (96.91s)
PASS
ok  	cloud.google.com/go/bigtable	99.516s

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jul 2, 2024
@bhshkh bhshkh marked this pull request as ready for review July 2, 2024 22:15
@bhshkh bhshkh requested review from a team July 2, 2024 22:15
@bhshkh bhshkh enabled auto-merge (squash) July 3, 2024 18:15
auto-merge was automatically disabled July 5, 2024 18:53

Pull Request is not mergeable

@bhshkh bhshkh added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jul 5, 2024
@bhshkh bhshkh enabled auto-merge (squash) July 7, 2024 06:29
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 8, 2024
@bhshkh bhshkh merged commit a428615 into googleapis:main Jul 8, 2024
@bhshkh bhshkh deleted the test/cbt-flaky branch July 8, 2024 17:53
@bhshkh bhshkh mentioned this pull request Jul 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigtable: TestIntegration_ArbitraryTimestamps failed bigtable: TestIntegration_AdminCopyBackup failed

3 participants

@bhshkh @gkevinzheng @kokoro-team