Skip to content

test(bigtable): Creating new table per test#10476

Merged
bhshkh merged 3 commits intogoogleapis:mainfrom
bhshkh:test/cbt-flaky-tests
Jul 1, 2024
Merged

test(bigtable): Creating new table per test#10476
bhshkh merged 3 commits intogoogleapis:mainfrom
bhshkh:test/cbt-flaky-tests

Conversation

@bhshkh
Copy link
Copy Markdown
Contributor

@bhshkh bhshkh commented Jul 1, 2024 •
edited
Loading

Multiple tests failed while creating table:

=== RUN   TestIntegration_HighlyConcurrentReadsAndWrites
    integration_test.go:3525: Running test against production
    integration_test.go:3555: Error creating table: rpc error: code = Internal desc = Internal error encountered.
    integration_test.go:709: rpc error: code = Internal desc = Internal error encountered.
--- FAIL: TestIntegration_HighlyConcurrentReadsAndWrites (0.89s)
=== RUN   TestIntegration_LargeReadsWritesAndScans
    integration_test.go:3525: Running test against production
    integration_test.go:3555: Error creating table: rpc error: code = Internal desc = Internal error encountered.
    integration_test.go:752: rpc error: code = Internal desc = Internal error encountered.
--- FAIL: TestIntegration_LargeReadsWritesAndScans (0.89s)
=== RUN   TestIntegration_Read
    integration_test.go:3525: Running test against production
    integration_test.go:3555: Error creating table: rpc error: code = Internal desc = Internal error encountered.
    integration_test.go:903: rpc error: code = Internal desc = Internal error encountered.
--- FAIL: TestIntegration_Read (0.86s)
=== RUN   TestIntegration_FullReadStats
    integration_test.go:3525: Running test against production
    integration_test.go:3555: Error creating table: rpc error: code = Internal desc = Internal error encountered.
    integration_test.go:1158: rpc error: code = Internal desc = Internal error encountered.
--- FAIL: TestIntegration_FullReadStats (0.30s)
=== RUN   TestIntegration_SampleRowKeys
    integration_test.go:3525: Running test against production
    integration_test.go:3555: Error creating table: rpc error: code = Internal desc = Internal error encountered.
    integration_test.go:1487: rpc error: code = Internal desc = Internal error encountered.
--- FAIL: TestIntegration_SampleRowKeys (0.88s)
=== RUN   TestIntegration_TableDeletionProtection
    integration_test.go:1562: Create table from config: rpc error: code = Internal desc = Internal error encountered.
--- FAIL: TestIntegration_TableDeletionProtection (0.20s)
=== RUN   TestIntegration_Admin
    integration_test.go:1756: Creating table: rpc error: code = Internal desc = Internal error encountered.
    integration_test.go:3615: DeleteTable: retry failed with context deadline exceeded; last error: rpc error: code = DeadlineExceeded desc = context deadline exceeded
--- FAIL: TestIntegration_Admin (62.13s)

This usually happens when zone / location is temporarily unavailable.
This PR adds retries for create table and independent tables for individual test

Fixes: #9420
Fixes: #10292
Fixes: #9365
Fixes: #9626
Fixes: #9627
Fixes: #9366

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jul 1, 2024
@bhshkh bhshkh marked this pull request as ready for review July 1, 2024 21:14
@bhshkh bhshkh requested review from a team July 1, 2024 21:14
@bhshkh bhshkh enabled auto-merge (squash) July 1, 2024 21:27
@bhshkh bhshkh merged commit 0a89ee6 into googleapis:main Jul 1, 2024
@bhshkh bhshkh deleted the test/cbt-flaky-tests branch July 1, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

2 participants

@bhshkh @gkevinzheng