Skip to content

chore(spanner): use previous version of cloud.google.com/go#10390

Merged
harshachinta merged 2 commits intogoogleapis:mainfrom
harshachinta:use-previous-version
Jun 19, 2024
Merged

chore(spanner): use previous version of cloud.google.com/go#10390
harshachinta merged 2 commits intogoogleapis:mainfrom
harshachinta:use-previous-version

Conversation

@harshachinta
Copy link
Copy Markdown
Contributor

@harshachinta harshachinta commented Jun 18, 2024

With https://github.com/googleapis/google-cloud-go/releases/tag/v0.115.0, the opencensus support is getting deprecated. This means customers would need to explicitly set an environment variable to opencensus for their traces. This is a breaking change for customers and we need to device a mechanism to avoid this.

Rolling back to previous version for few more days to avoid this breaking change.

Just a note: to avoid this we will need to implement one of the following options,

  1. So one option is to remove dependency on internal trace package and bring that tracing code into spanner.
  2. Set the environment variable or call the opencensustracing setter by default on spanner client library.

@harshachinta harshachinta requested review from a team June 18, 2024 09:06
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jun 18, 2024
@harshachinta harshachinta requested a review from rahul2393 June 18, 2024 09:09
@harshachinta harshachinta merged commit 36b70b7 into googleapis:main Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants