test(storage): use long uidSpace for buckets#10339
Merged
gcf-merge-on-green[bot] merged 1 commit intoJun 5, 2024
Merged
Conversation
Short uids are too short for the number of tests we have now. Use a long space (6 digits instead of 2). Tested locally and ensured that bucket names are still within GCS limits (63 chars max). Fixes googleapis#10338 Fixes googleapis#10337 Fixes googleapis#10336 Fixes googleapis#10335 Fixes googleapis#10334 Fixes googleapis#10333
BrennaEpp
approved these changes
Jun 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short uids are too short for the number of tests we have now. Use a long space (6 digits instead of 2). Tested locally and ensured that bucket names are still within GCS limits (63 chars max).
Fixes #10338
Fixes #10337
Fixes #10336
Fixes #10335
Fixes #10334
Fixes #10333