fix(storage): disable gax retries for gRPC #9747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All gRPC ops are retried as needed at the handwritten layer. Disable gax retries.
Contributor
Author
|
It looks like this exposed a bunch of conformance test failures; I'm going to fix and update. |
Contributor
Author
Okay, this was only because of a change in how things that are unimplemented in the testbench are handled in the retry test framework. I fixed this and all tests now pass. |
BrennaEpp
approved these changes
Apr 11, 2024
Contributor
BrennaEpp
left a comment
There was a problem hiding this comment.
One suggestion that doesn't change the functionality, otherwise LGTM.
We should also look into dropping withGAXOptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All gRPC ops are retried as needed at the handwritten layer. Disable gax retries.