fix(spanner): MarshalJSON function caused errors for certain values#9063
Merged
rahul2393 merged 2 commits intogoogleapis:mainfrom Nov 30, 2023
Merged
fix(spanner): MarshalJSON function caused errors for certain values#9063rahul2393 merged 2 commits intogoogleapis:mainfrom
rahul2393 merged 2 commits intogoogleapis:mainfrom
Conversation
Fix inspired by the bigquery package
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
rahul2393
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue in the implementation of the Marshaler interface within the spanner package.
The current implementation leads to errors when dealing with certain special characters, such as certain emojis. To resolve this issue, I have adopted an approach similar to that used in the
bigquerypackage, which is not affected by this problem.The root cause of the problem lies in the use of Sprintf, which may seem appealing but lacks the advantages of checks and escapes provided by the
encoding/jsonpackage. This pull request aims to rectify the situation by using thejson.Marshal.To validate the proposed solution, a small sample code is provided below that reproduces the error with the current implementation and demonstrates that the proposed changes resolve the issue:
Output before the fix :
Expected output :