feat(spanner): enable client to server compression#7899
Merged
Conversation
olavloite
approved these changes
May 12, 2023
Contributor
olavloite
left a comment
There was a problem hiding this comment.
LGTM (with a potential request for a test), assuming that it has been verified that the setting actually has an effect (e.g. by looking at the actual number of bytes sent/received)
spanner/client.go
Outdated
| internaloption.EnableDirectPath(true), | ||
| } | ||
| if compression == "gzip" { | ||
| clientDefaultOpts = append(clientDefaultOpts, option.WithGRPCDialOption(grpc.WithDefaultCallOptions( |
Contributor
There was a problem hiding this comment.
Would it be possible to add a test with the mock Spanner server that verifies that we actually receive this header?
Contributor
Author
There was a problem hiding this comment.
Added the unit test for checking the request headers, also adding screenshot to verify all the grpc requests will have the call option for setting compression
Contributor
There was a problem hiding this comment.
Thanks for the extra info and adding the test. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable compression of network traffic from client to server.