Skip to content

fix(spanner/spansql): fix SQL for CREATE CHANGE STREAM TableName; case#7514

Merged
rahul2393 merged 2 commits intogoogleapis:mainfrom
nktks:fix/spansql-cs-sql
Mar 7, 2023
Merged

fix(spanner/spansql): fix SQL for CREATE CHANGE STREAM TableName; case#7514
rahul2393 merged 2 commits intogoogleapis:mainfrom
nktks:fix/spansql-cs-sql

Conversation

@nktks
Copy link
Copy Markdown
Contributor

@nktks nktks commented Mar 6, 2023 •
edited
Loading

This PR fixes CreateChangeStream's SQL() outputs for the case parsed CREATE CHANGE STREAM TableName;.

Reproduce Code:
main.go

package main

import (
	"fmt"

	"cloud.google.com/go/spanner/spansql"
)

func main() {
	fmt.Printf(spansql.CreateChangeStream{
		Name: "csname",
	}.SQL())
}

expected

CREATE CHANGE STREAM csname

actual

go run main.go
CREATE CHANGE STREAM csname FOR

@nktks nktks requested review from a team March 6, 2023 15:41
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the Spanner API. labels Mar 6, 2023
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2023
@rahul2393 rahul2393 merged commit fc5fd86 into googleapis:main Mar 7, 2023
@release-please release-please bot mentioned this pull request Mar 7, 2023
Merged
@nktks nktks deleted the fix/spansql-cs-sql branch March 7, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nktks @rahul2393 @kokoro-team