feat(spanner): add database roles#5701
Merged
rahul2393 merged 22 commits intogoogleapis:mainfrom Dec 14, 2022
Merged
Conversation
Contributor
|
Adding do not merge label to avoid accidental merges. |
rahul2393
reviewed
Apr 26, 2022
Contributor
rahul2393
left a comment
There was a problem hiding this comment.
LGTM, any reasons why we did not dd the role in BatchCreateSessions requests?
hmehrotra
reviewed
Apr 27, 2022
hmehrotra
left a comment
There was a problem hiding this comment.
Other TODO's
-
Add tests that use DROP ROLE, REVOKE. (We don't need to test role inheritance, thats sufficiently covered in backend unit tests.
-
Implement/Add tests for ListDatabaseRoles.
Contributor
Author
I did add it, it's part of
I added these to I'll work on ListDatabaseRoles soon. |
7cc0651 to
3ada697
Compare
bf8dc11 to
1d7195c
Compare
rahul2393
approved these changes
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to specify a database role on requests.