fix(storage): skip download of file outside of target dir #12945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpriti-os
requested changes
Sep 25, 2025
cpriti-os
approved these changes
Oct 6, 2025
tritone
reviewed
Oct 6, 2025
Contributor
tritone
left a comment
There was a problem hiding this comment.
Looks good but I'm curious about the decision to log the skipped files and not return an error from Downloader.
Also, did you run the transfermanager integration tests locally?
cpriti-os
requested changes
Oct 7, 2025
tritone
reviewed
Oct 7, 2025
Contributor
tritone
left a comment
There was a problem hiding this comment.
Couple more suggestions but otherwise LGTM
cpriti-os
requested changes
Oct 8, 2025
tritone
reviewed
Oct 8, 2025
Contributor
tritone
left a comment
There was a problem hiding this comment.
Couple comments on the tests you added, otherwise looks good.
tritone
approved these changes
Oct 8, 2025
cpriti-os
approved these changes
Oct 9, 2025
krishnamd-jkp
pushed a commit
that referenced
this pull request
Oct 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.57.1](storage/v1.57.0...storage/v1.57.1) (2025-10-28) ### Bug Fixes * **storage:** Takeover idempotence. ([#13230](#13230)) ([cc5d2a1](cc5d2a1)) * **storage:** Copy metadata when using Copier with grpc ([#12919](#12919)) ([57a2e80](57a2e80)) * **storage:** Fix takeover response handling. ([#13239](#13239)) ([26d75bc](26d75bc)) * **storage:** Remove default timeout for gRPC operations ([#13022](#13022)) ([b94c3ba](b94c3ba)) * **storage:** Skip download of file outside of target dir ([#12945](#12945)) ([6259aee](6259aee)) * **storage:** Upgrade gRPC service registration func ([8fffca2](8fffca2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Brenna N Epp <brennae@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces logic in transfermanager download directories flow where the objects are skipped if the download path is outside of target directory. The changes directly add the results of such objects using addResult method bypassing the addition of such objects to workers channel