Skip to content

feat(bigtable): Record client_blocking_latencies #12698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bhshkh merged 9 commits into from
Aug 15, 2025
Merged

feat(bigtable): Record client_blocking_latencies #12698

bhshkh merged 9 commits into from
Aug 15, 2025

Conversation

@bhshkh
Copy link
Contributor

@bhshkh bhshkh commented Aug 12, 2025 •
edited
Loading

This PR adds client_blocking_latencies metrics. More about the metric can be found at https://cloud.google.com/bigtable/docs/client-side-metrics-descriptions#client-blocking-latencies

@bhshkh bhshkh requested review from a team as code owners August 12, 2025 16:15
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Aug 12, 2025
@danowar2
Copy link

danowar2 commented Aug 12, 2025

Think I need a new available for Data

@bhshkh bhshkh force-pushed the feature/cbt-client-blocking-latencies-pr branch from 96b7f73 to c1aa6eb Compare August 12, 2025 17:31
@bhshkh bhshkh requested review from a team, jba and shollyman as code owners August 12, 2025 17:31
@bhshkh bhshkh requested a review from cindy-peng August 12, 2025 17:31
@snippet-bot
Copy link

snippet-bot bot commented Aug 12, 2025 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@bhshkh bhshkh force-pushed the feature/cbt-client-blocking-latencies-pr branch from e21c9ab to 7772b51 Compare August 12, 2025 17:40
@bhshkh bhshkh removed request for a team August 12, 2025 17:41
@bhshkh bhshkh removed request for a team, cindy-peng, jba and shollyman August 12, 2025 17:41
@bhshkh bhshkh marked this pull request as draft August 12, 2025 17:42
@bhshkh bhshkh force-pushed the feature/cbt-client-blocking-latencies-pr branch from 7772b51 to 7c4d669 Compare August 12, 2025 17:43
mutianf
mutianf reviewed Aug 12, 2025
View reviewed changes
@bhshkh bhshkh marked this pull request as ready for review August 13, 2025 20:33
sushanb
sushanb previously approved these changes Aug 14, 2025
View reviewed changes
mutianf
mutianf previously approved these changes Aug 14, 2025
View reviewed changes
@bhshkh bhshkh dismissed stale reviews from mutianf and sushanb via 39ba551 August 14, 2025 19:18
@bhshkh bhshkh enabled auto-merge (squash) August 14, 2025 19:18
@bhshkh bhshkh merged commit 5f03fb3 into googleapis:main Aug 15, 2025
11 checks passed
@bhshkh bhshkh deleted the feature/cbt-client-blocking-latencies-pr branch August 15, 2025 19:20
@release-please release-please bot mentioned this pull request Aug 15, 2025
Merged
@bhshkh bhshkh linked an issue Sep 30, 2025 that may be closed by this pull request
bigtable: Support client side metrics #12997
Closed
@bhshkh bhshkh removed a link to an issue Sep 30, 2025
bigtable: Support client side metrics #12997
Closed
@bhshkh bhshkh linked an issue Sep 30, 2025 that may be closed by this pull request
bigtable: Client side metrics: advanced metrics #13002
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mutianf mutianf mutianf approved these changes

@sushanb sushanb sushanb left review comments

+1 more reviewer

@danowar2 danowar2 danowar2 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigtable: Client side metrics: advanced metrics

4 participants

@bhshkh @danowar2 @mutianf @sushanb