Skip to content

perf(bigtable): Create attributes only when enabled#12647

Merged
bhshkh merged 1 commit into
googleapis:mainfrom
bhshkh:perf/cbt-create-tracer
Aug 12, 2025
Merged

perf(bigtable): Create attributes only when enabled#12647
bhshkh merged 1 commit into
googleapis:mainfrom
bhshkh:perf/cbt-create-tracer

Conversation

@bhshkh

@bhshkh bhshkh commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Currently, client attributes are created and clientUID is generated even if metrics have been disabled by the user.
In this PR,

  • the code has been rearranged to avoid this.
  • benchmark tests have been added
    Without the rearrangement
BenchmarkReadRowsWithoutMetrics
    benchmark_test.go:43: Setting up for metrics enabled: false
    benchmark_test.go:53: Creating table: profile-test-cfc95c17-d4b7-405e-930e-eb5a88eb6e2c
    benchmark_test.go:69: Writing 1000000 rows to table 'profile-test-cfc95c17-d4b7-405e-930e-eb5a88eb6e2c' with prefix 'row-baa2666c-12c6-4884-a0bc-776b2ad68e4c'...
    benchmark_test.go:78: Finished writing data.
    benchmark_test.go:108: Running cleanup...
    benchmark_test.go:120: Cleanup complete.
BenchmarkReadRowsWithoutMetrics-8   	       1	1194657088 ns/op	1185699328 B/op	14093841 allocs/op

With the rearrangment in this PR:

BenchmarkReadRowsWithoutMetrics
    benchmark_test.go:43: Setting up for metrics enabled: false
    benchmark_test.go:53: Creating table: profile-test-5ad21bfd-67b9-4e33-aeb0-bd6d5eb92470
    benchmark_test.go:69: Writing 1000000 rows to table 'profile-test-5ad21bfd-67b9-4e33-aeb0-bd6d5eb92470' with prefix 'row-28a2fc38-b784-4307-9854-25a5626e23b0'...
    benchmark_test.go:78: Finished writing data.
    benchmark_test.go:108: Running cleanup...
    benchmark_test.go:120: Cleanup complete.
BenchmarkReadRowsWithoutMetrics-8   	       1	1170956968 ns/op	1151702784 B/op	14092822 allocs/op

Here’s what each part of the output line:

  • ns/op (Nanoseconds per Operation): This is the average time it took to run the operation once. A lower number is better, indicating the code is faster.
  • B/op (Bytes per Operation): This measures the average amount of memory allocated on the heap for each operation. A lower number is better, meaning your code is more memory-efficient.
  • allocs/op (Allocations per Operation): This is the average number of distinct memory allocations made per operation. Fewer allocations generally mean less work for the garbage collector and can lead to better performance. A lower number is better.
Metric Without rearrangment With rearrangment Improvement
Time (ns/op) 1,194,657,088 1,170,956,968 23,700,120 ns (2.0% faster)
Memory (B/op) 1,185,699,328 1,151,702,784 33,996,544 B (2.9% less memory)
Allocations (allocs/op) 14,093,841 14,092,822 1,019 fewer allocations

@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Aug 5, 2025
@bhshkh bhshkh changed the title perf(bigtable): Create OTEL instruments only when client side metrics… perf(bigtable): Create attributes only when enabled Aug 5, 2025
@bhshkh bhshkh marked this pull request as ready for review August 5, 2025 10:53
@bhshkh bhshkh requested review from a team August 5, 2025 10:53
@bhshkh bhshkh enabled auto-merge (squash) August 5, 2025 10:53
@bhshkh bhshkh force-pushed the perf/cbt-create-tracer branch from 4267ef0 to 2e79b3c Compare August 6, 2025 01:51
@bhshkh bhshkh force-pushed the perf/cbt-create-tracer branch from 2e79b3c to 845b6b1 Compare August 6, 2025 08:03
@bhshkh bhshkh merged commit aa31abc into googleapis:main Aug 12, 2025
11 checks passed
@release-please release-please Bot mentioned this pull request Aug 12, 2025
Merged
@bhshkh bhshkh deleted the perf/cbt-create-tracer branch August 12, 2025 18:27
This was linked to issues Sep 30, 2025
bigtable: Support client side metrics #12997
Closed
bigtable: Client side metrics performance improvements #12998
Closed
This was unlinked from issues Sep 30, 2025
bigtable: Support client side metrics #12997
Closed
bigtable: Client side metrics performance improvements #12998
Closed
@bhshkh bhshkh linked an issue Sep 30, 2025 that may be closed by this pull request
bigtable: Client side metrics performance improvements #12998
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gkevinzheng gkevinzheng gkevinzheng approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bigtable: Client side metrics performance improvements

2 participants

@bhshkh @gkevinzheng