fix(spanner): Fix blind retry for ResourceExhausted#12523
Merged
sakthivelmanii merged 3 commits intomainfrom Jul 8, 2025
Merged
fix(spanner): Fix blind retry for ResourceExhausted#12523sakthivelmanii merged 3 commits intomainfrom
sakthivelmanii merged 3 commits intomainfrom
Conversation
olavloite
previously approved these changes
Jul 7, 2025
b824b5c to
7fc236f
Compare
olavloite
approved these changes
Jul 8, 2025
rahul2393
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently, we are doing blind retry for ResourceExhausted which is not expected as per go/cloud-spanner-flow-control-propagation. Expectation is that if there is a retry info, and if it has server delay then we should retry it.
Java implementation: https://github.com/googleapis/java-spanner/blob/f4efd7afe6b86adbd6a920f4791093efcd39ce67/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerExceptionFactory.java#L327
Fixes #11134