feat(bigtable/spanner): allow disable gRPC DirectPath deps #12469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc: @mohanli-ml @bhshkh |
Contributor
Author
|
Hey, can we have a review soon? |
bhshkh
previously approved these changes
Jun 23, 2025
Contributor
|
Please add description mentioning what is being done and why. Create an issue here https://github.com/googleapis/google-cloud-go/issues to describe what is the problem being solved. |
Contributor
Author
|
@bhshkh Created an issue, and updated the description. |
Contributor
Author
|
@bhshkh ping, please help me to reviews and merge this PR. |
Contributor
Author
|
Hello, please unblock me with this @rahul2393 |
bhshkh
approved these changes
Jul 2, 2025
rahul2393
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the PR #10757 to allow disabling gRPC DirectPath using the build tag
disable_grpc_modules.This PR is trying to resolve the same issue as mentioned in #12343 for Spanner and BigTable client.
Closes: #12488