feat(spanner): allow string values for Scan functions#11898
Merged
Conversation
Support scanning string values for the various spanner.NullTypes. Use the Scan implementation of the underlying data type for spanner.NullDate, as civil.Date now implements the sql.Scanner interface. The Scan implementations are used by the database/sql driver and applications that depend on the database/sql driver.
rahul2393
approved these changes
Mar 24, 2025
Contributor
|
related issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support scanning string values for the various
spanner.NullTypes.
Use the Scan implementation of the underlying data type for spanner.NullDate, as civil.Date now implements the sql.Scanner interface.
The Scan implementations are used by the database/sql driver and applications that depend on the database/sql driver.