fix(spanner): avoid desructive context augmentation that dropped all headers#11659
Merged
olavloite merged 2 commits intogoogleapis:mainfrom Feb 26, 2025
Conversation
86195d8 to
49061e5
Compare
olavloite
approved these changes
Feb 26, 2025
Contributor
olavloite
left a comment
There was a problem hiding this comment.
LGTM, with some nits on the test. We can pick that up in a follow-up PR as well if we want to ship this ASAP.
…headers This change fixes a destructive context operation that dropped all prior headers, metadata.NewOutgoingContext sadly doesn't document that it doesn't reuse the input conext negating the expectation in Go that building from a parent context brings along the prior keys and metadata. While here, this chhange adds a regression test to ensure that in the future, any dropped or lost metadata will be reported during development. Fixes googleapis#11656
76ea4eb to
d70b849
Compare
Contributor
Author
|
@olavloite kindly help me re-run the bots! |
larryanz
pushed a commit
to larryanz/google-cloud-go
that referenced
this pull request
Feb 27, 2025
…headers (googleapis#11659) * fix(spanner): avoid desructive context augmentation that dropped all headers This change fixes a destructive context operation that dropped all prior headers, metadata.NewOutgoingContext sadly doesn't document that it doesn't reuse the input conext negating the expectation in Go that building from a parent context brings along the prior keys and metadata. While here, this chhange adds a regression test to ensure that in the future, any dropped or lost metadata will be reported during development. Fixes googleapis#11656 * Address review feedback+nits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a destructive context operation that dropped all prior headers, metadata.NewOutgoingContext sadly doesn't document that it doesn't reuse the input conext negating the expectation in Go that building from a parent context brings along the prior keys and metadata. While here, this chhange adds a regression test to ensure that in the future, any dropped or lost metadata will be reported during development.
Fixes #11656