feat(storage): Benchmark with experimental MRD.#11501
Merged
Merged
Conversation
Allow benchmarks to use the experimental MultiRangeDownloader for normal range reads. Note that this does not use a single MultiRangeDownloader across multiple reads, which is supported but would require a more invasive change to the benchmark.
tritone
reviewed
Jan 29, 2025
| if config.readBufferSize != useDefault { | ||
| opts = append(opts, option.WithGRPCDialOption(grpc.WithReadBufferSize(config.readBufferSize))) | ||
| } | ||
| if config.useMultiRangeDownloader { |
Contributor
There was a problem hiding this comment.
I think this would only use bidi reads via storage.Reader, not actually use MultiRangeDownloader.
I think this is fine but maybe we should rename the opt; or just have Bidi reads be a transport option instead?
Contributor
Author
There was a problem hiding this comment.
useMultiRangeDownloaderForSingleRangeReads?
It gets a little unwieldy :) But I agree that users might be a little misled by the current name. I'm open to suggestions.
Contributor
There was a problem hiding this comment.
+1 to Chris, I would go with having the option for bidi reads
Contributor
Author
There was a problem hiding this comment.
Done, renamed to useGRPCBidiReads to match the experimental option
BrennaEpp
approved these changes
Feb 11, 2025
tritone
approved these changes
Feb 12, 2025
This was referenced Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow benchmarks to use the experimental MultiRangeDownloader for normal range reads.
Note that this does not use a single MultiRangeDownloader across multiple reads, which is supported but would require a more invasive change to the benchmark.