feat(storage): add Writer.ChunkTransferTimeout#11111
Merged
gcf-merge-on-green[bot] merged 23 commits intoDec 4, 2024
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
46290c0 to
b0fa899
Compare
2d3b63a to
adf32f8
Compare
tritone
reviewed
Nov 25, 2024
tritone
left a comment
Contributor
There was a problem hiding this comment.
Some suggestions on testing/docs
tritone
reviewed
Nov 27, 2024
tritone
left a comment
Contributor
There was a problem hiding this comment.
LGTM, we can merge once the apiary release happens and dependency is picked up.
85f44db to
46056b3
Compare
46056b3 to
092400e
Compare
4246d5b to
de93ea1
Compare
tritone
approved these changes
Dec 4, 2024
This was referenced Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the ChunkTransferTimeout MediaOption through the manual
client layer. This allows users to set a longer timeout for
chunk retries in case of stalls in resumable uploads if desired.
Added emulator based unit tests to cover all the scenarios.