Skip to content

fix(spanner): allow non default service account only when direct path is enabled#11046

Merged
rahul2393 merged 4 commits intomainfrom
use-non-default-sa-when-dp-enabled
Nov 14, 2024
Merged

fix(spanner): allow non default service account only when direct path is enabled#11046
rahul2393 merged 4 commits intomainfrom
use-non-default-sa-when-dp-enabled

Conversation

@rahul2393
Copy link
Copy Markdown
Contributor

@rahul2393 rahul2393 commented Oct 29, 2024

No description provided.

@rahul2393 rahul2393 requested review from a team October 29, 2024 04:36
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Oct 29, 2024
@rahul2393 rahul2393 requested a review from mohanli-ml October 29, 2024 04:37
@rahul2393
Copy link
Copy Markdown
Contributor Author

rahul2393 commented Oct 29, 2024

cc: @HailongWen

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 13, 2024
nimf
nimf approved these changes Nov 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nimf nimf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rahul2393 rahul2393 removed the request for review from mohanli-ml November 14, 2024 03:33
@rahul2393 rahul2393 merged commit 4250788 into main Nov 14, 2024
@rahul2393 rahul2393 deleted the use-non-default-sa-when-dp-enabled branch November 14, 2024 04:14
@release-please release-please bot mentioned this pull request Nov 14, 2024
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 14, 2024
@release-please
chore(main): release spanner 1.73.0 (#11116)
f06a55a 
🤖 I have created a release *beep* *boop*
---


## [1.73.0](https://togithub.com/googleapis/google-cloud-go/compare/spanner/v1.72.0...spanner/v1.73.0) (2024-11-14)


### Features

* **spanner:** Add ResetForRetry method for stmt-based transactions ([#10956](https://togithub.com/googleapis/google-cloud-go/issues/10956)) ([02c191c](https://togithub.com/googleapis/google-cloud-go/commit/02c191c5dc13023857812217f63be2395bfcb382))


### Bug Fixes

* **spanner:** Add safecheck to avoid deadlock when creating multiplex session ([#11131](https://togithub.com/googleapis/google-cloud-go/issues/11131)) ([8ee5d05](https://togithub.com/googleapis/google-cloud-go/commit/8ee5d05e288c7105ddb1722071d6719933effea4))
* **spanner:** Allow non default service account only when direct path is enabled ([#11046](https://togithub.com/googleapis/google-cloud-go/issues/11046)) ([4250788](https://togithub.com/googleapis/google-cloud-go/commit/42507887523f41d0507ca8b1772235846947c3e0))
* **spanner:** Use spanner options when initializing monitoring exporter ([#11109](https://togithub.com/googleapis/google-cloud-go/issues/11109)) ([81413f3](https://togithub.com/googleapis/google-cloud-go/commit/81413f3647a0ea406f25d4159db19b7ad9f0682b))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nimf nimf nimf approved these changes

+1 more reviewer

@harshachinta harshachinta harshachinta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rahul2393 @nimf @harshachinta @kokoro-team