Skip to content

feat(spanner): client built in metrics#10998

Merged
rahul2393 merged 4 commits intomainfrom
built_in_metrics_enable
Nov 1, 2024
Merged

feat(spanner): client built in metrics#10998
rahul2393 merged 4 commits intomainfrom
built_in_metrics_enable

Conversation

@rahul2393
Copy link
Copy Markdown
Contributor

@rahul2393 rahul2393 commented Oct 16, 2024

This PR enables client built-in metrics as default.

Client built-in metrics support was added in PR #10419

Below 4 metrics are introduced with this feature.

spanner.googleapis.com/client/operation_count
spanner.googleapis.com/client/operation_latencies
spanner.googleapis.com/client/attempt_count
spanner.googleapis.com/client/attempt_latencies

To opt-out from client metrics

client, err := spanner.NewClientWithConfig(ctx, "projects/my-project/instances/my-instance/database/my-db", spanner.ClientConfig{
		DisableNativeMetrics: true,
	})

@rahul2393 rahul2393 requested review from a team October 16, 2024 06:57
@rahul2393 rahul2393 force-pushed the built_in_metrics_enable branch from ed73c7b to a9ada9b Compare October 16, 2024 06:58
@rahul2393 rahul2393 changed the title feat: client built in metrics feat(spanner): client built in metrics Oct 16, 2024
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Oct 16, 2024
@rahul2393 rahul2393 requested a review from olavloite October 16, 2024 08:25
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 29, 2024
@rahul2393 rahul2393 enabled auto-merge (squash) November 1, 2024 10:16
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2024
@rahul2393 rahul2393 merged commit d81a1a7 into main Nov 1, 2024
@rahul2393 rahul2393 deleted the built_in_metrics_enable branch November 1, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants