Skip to content

feat(storage): dynamic read request stall timeout#10958

Merged
gcf-merge-on-green[bot] merged 12 commits into
googleapis:mainfrom
raj-prince:read-req-dtimeout
Oct 14, 2024
Merged

feat(storage): dynamic read request stall timeout#10958
gcf-merge-on-green[bot] merged 12 commits into
googleapis:mainfrom
raj-prince:read-req-dtimeout

Conversation

@raj-prince

@raj-prince raj-prince commented Oct 7, 2024

Copy link
Copy Markdown
Contributor
  • Adding a new storage client option to enable pro-actively retry for stalled request based on dynamic timeout.
  • Added emulator test to validated the changes.

@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Oct 7, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Oct 7, 2024
@raj-prince raj-prince marked this pull request as ready for review October 8, 2024 18:29
@raj-prince raj-prince requested review from a team October 8, 2024 18:29

@tritone tritone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall, a few more minor points.

Comment thread storage/option.go Outdated
Comment thread storage/client_test.go
Comment thread storage/option.go Outdated
Comment thread storage/option.go Outdated

@tritone tritone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more docs and defaults suggestions. Also, please follow #10984 to start an experimental package for the option.

Comment thread storage/option.go Outdated
Comment thread storage/option.go Outdated
Comment thread storage/option.go Outdated
@raj-prince raj-prince requested a review from tritone October 13, 2024 03:26
Comment thread storage/option.go Outdated
Comment thread storage/option.go Outdated
@raj-prince raj-prince requested a review from tritone October 14, 2024 01:05

@tritone tritone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tritone tritone added the automerge Merge the pull request once unit tests and other checks pass. label Oct 14, 2024
@gcf-merge-on-green gcf-merge-on-green Bot merged commit a09f00e into googleapis:main Oct 14, 2024
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants