Skip to content

feat(storage/dataflux): add worksteal algorithm to fast-listing#10913

Merged
BrennaEpp merged 12 commits into
googleapis:mainfrom
akansha1812:main
Sep 29, 2024
Merged

feat(storage/dataflux): add worksteal algorithm to fast-listing#10913
BrennaEpp merged 12 commits into
googleapis:mainfrom
akansha1812:main

Conversation

@akansha1812

@akansha1812 akansha1812 commented Sep 25, 2024

Copy link
Copy Markdown
Contributor

feat: add worksteal algorithm to fast-listing
Dataflux fast-listing will be used to quickly list objects in a bucket in parallel leveraging worksteal algorithm.

Worksteal algorithm splits a given namespace into multiple ranges for multiple workers(goroutines) to list objects in gcs bucket in parallel.

Fixes #10731

@akansha1812 akansha1812 requested review from a team September 25, 2024 00:10
@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Sep 25, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Sep 25, 2024
@akansha1812 akansha1812 changed the title feat(storage/dataflux): adding worksteal algorithm for listing feat(storage/dataflux): add worksteal algorithm to fast-listing Sep 25, 2024

@BrennaEpp BrennaEpp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial thoughts. This should be tested for race conditions as well but that can be as integration tests in the follow up.

Comment thread storage/dataflux/fast_list.go Outdated
Comment thread storage/dataflux/fast_list.go
Comment thread storage/dataflux/fast_list.go
Comment thread storage/dataflux/fast_list.go
Comment thread storage/dataflux/fast_list.go Outdated
Comment thread storage/dataflux/worksteal.go
Comment thread storage/dataflux/worksteal.go Outdated
Comment thread storage/dataflux/worksteal.go
Comment thread storage/dataflux/worksteal.go Outdated
Comment thread storage/dataflux/worksteal.go Outdated
Comment thread storage/dataflux/fast_list_test.go Outdated
Comment thread storage/dataflux/worksteal.go
Comment thread storage/dataflux/worksteal.go
Comment thread internal/testutil/context.go Outdated
Comment thread storage/dataflux/worksteal.go Outdated
Comment thread storage/dataflux/worksteal.go Outdated

@BrennaEpp BrennaEpp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

storage: implement dataflux fast listing

2 participants