Skip to content

fix(spanner): check errors in tests#10738

Merged
rahul2393 merged 5 commits intogoogleapis:mainfrom
egonelbre:errors2
Sep 25, 2024
Merged

fix(spanner): check errors in tests#10738
rahul2393 merged 5 commits intogoogleapis:mainfrom
egonelbre:errors2

Conversation

@egonelbre
Copy link
Copy Markdown
Contributor

@egonelbre egonelbre commented Aug 22, 2024 •
edited
Loading

  • fix(spanner): add missing error checks to tests
  • fix(spanner): check error before using client in test
  • chore(spanner): remove redundant return-s

Updates #9784

@egonelbre egonelbre requested review from a team August 22, 2024 13:46
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Aug 22, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2024
@rahul2393 rahul2393 merged commit 971bfb8 into googleapis:main Sep 25, 2024
@release-please release-please bot mentioned this pull request Sep 25, 2024
Merged
@egonelbre egonelbre deleted the errors2 branch September 25, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

Assignees

No one assigned

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@egonelbre @rahul2393 @kokoro-team