Skip to content

feat(spanner): Add RESOURCE_EXHAUSTED to retryable transaction codes#10412

Merged
rahul2393 merged 12 commits intogoogleapis:mainfrom
Vizerai:retry_transaction
Jul 18, 2024
Merged

feat(spanner): Add RESOURCE_EXHAUSTED to retryable transaction codes#10412
rahul2393 merged 12 commits intogoogleapis:mainfrom
Vizerai:retry_transaction

Conversation

@Vizerai
Copy link
Copy Markdown
Contributor

@Vizerai Vizerai commented Jun 21, 2024

feat: Add RESOURCE_EXHAUSTED to retryable transaction codes.

This is part of the SpanFe flow control work.

@Vizerai Vizerai requested review from a team June 21, 2024 19:35
@Vizerai Vizerai changed the title Add RESOURCE_EXHAUSTED to retryable transaction codes feat: Add RESOURCE_EXHAUSTED to retryable transaction codes Jun 21, 2024
@Vizerai Vizerai force-pushed the retry_transaction branch from 5a343a5 to e697a1e Compare June 21, 2024 20:01
@codyoss codyoss changed the title feat: Add RESOURCE_EXHAUSTED to retryable transaction codes feat(spanner): Add RESOURCE_EXHAUSTED to retryable transaction codes Jun 21, 2024
@Vizerai Vizerai force-pushed the retry_transaction branch from 3679e52 to eaca4e7 Compare June 22, 2024 01:50
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jun 22, 2024
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2024
@Vizerai
Copy link
Copy Markdown
Contributor Author

Vizerai commented Jul 17, 2024

@rahul2393 can you add googleapis/yoshi-go-admins as a reviewer? I cannot add anyone to the reviewer list.

@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2024
@rahul2393 rahul2393 enabled auto-merge (squash) July 18, 2024 02:11
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2024
@rahul2393
Copy link
Copy Markdown
Contributor

@Vizerai I can review and merge this PR, there is a build failure though

./retry_test.go:123:6: TestRetryerRespectsServerDelay redeclared in this block
	./retry_test.go:102:6: other declaration of TestRetryerRespectsServerDelay

Can you please fix that?

auto-merge was automatically disabled July 18, 2024 05:02

Head branch was pushed to by a user without write access

@rahul2393 rahul2393 enabled auto-merge (squash) July 18, 2024 05:16
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 18, 2024
@rahul2393 rahul2393 merged commit 29b52dc into googleapis:main Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants