fix(spanner): prevent possible panic for Session not found errors#10386
Merged
fix(spanner): prevent possible panic for Session not found errors#10386
Conversation
The Spanner client library could panic if specifically the following situation would occur: 1. Create a StmtBasedReadWriteTransaction 2. Only execute mutations, so that an explicit BeginTransaction RPC is required. 3. The BeginTransaction RPC returns "Session not found" 4. The client library tries to get a new session from the pool. Step 4 above would panic, because the client library did not set the readOnlyTransaction.sp field for StmtBasedReadWriteTransactions. Fixes #10385
rahul2393
approved these changes
Jun 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Spanner client library could panic if specifically the following situation would occur:
Step 4 above would panic, because the client library did not set the readOnlyTransaction.sp field for StmtBasedReadWriteTransactions.
Fixes #10385
Also fixes googleapis/go-sql-spanner#262