Skip to content

Commit d4f2449

Browse files
authored
docs(bigtable): Add todos (#11280)
1 parent ac4ad51 commit d4f2449

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

bigtable/bigtable.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,10 +126,10 @@ func NewClientWithConfig(ctx context.Context, project, instance string, config C
126126
o = append(o, internaloption.AllowNonDefaultServiceAccount(true))
127127
o = append(o, opts...)
128128

129+
// TODO(b/372244283): Remove after b/358175516 has been fixed
129130
asyncRefreshMetricAttrs := metricsTracerFactory.clientAttributes
130131
asyncRefreshMetricAttrs = append(asyncRefreshMetricAttrs,
131132
attribute.String(metricLabelKeyTag, "async_refresh_dry_run"),
132-
133133
// Table, cluster and zone are unknown at this point
134134
// Use default values
135135
attribute.String(monitoredResLabelKeyTable, defaultTable),
@@ -140,9 +140,10 @@ func NewClientWithConfig(ctx context.Context, project, instance string, config C
140140
metricsTracerFactory.debugTags.Add(context.Background(), 1,
141141
metric.WithAttributes(asyncRefreshMetricAttrs...))
142142
}))
143+
143144
connPool, err := gtransport.DialPool(ctx, o...)
144145
if err != nil {
145-
return nil, fmt.Errorf("dialing: %w", err)
146+
return nil, err
146147
}
147148

148149
return &Client{

0 commit comments

Comments
 (0)