fix(bigquery/storage/managedwriter): automatic retry for multiplex test (#8601)

shollyman · web-flow · commit 6ef1945a8374 · 2023-09-21T10:53:40.000-07:00
In #8599 we caught a flake related to DeadlineExceeded errors. This class of error is retryable, so we set the EnableWriteRetries option when constructing writers to address this. The DE was likely raised from the service side, as in this case the test ran for ~32s (deadline is 90) and normal execution time should be sub-10s. This is also borne out by the problematic writes, which were both destined for the same table. Fixes: #8599
diff --git a/bigquery/storage/managedwriter/integration_test.go b/bigquery/storage/managedwriter/integration_test.go
@@ -1498,6 +1498,7 @@ func TestIntegration_MultiplexWrites(t *testing.T) {
 				WithDestinationTable(TableParentFromParts(testTable.tbl.ProjectID, testTable.tbl.DatasetID, testTable.tbl.TableID)),
 				WithType(DefaultStream),
 				WithSchemaDescriptor(testTable.dp),
+				EnableWriteRetries(true),
 			)
 			if err != nil {
 				t.Fatalf("NewManagedStream %d: %v", k, err)

Original file line number	Diff line number	Diff line change
`@@ -1498,6 +1498,7 @@ func TestIntegration_MultiplexWrites(t *testing.T) {`
`1498`	`1498`	`WithDestinationTable(TableParentFromParts(testTable.tbl.ProjectID, testTable.tbl.DatasetID, testTable.tbl.TableID)),`
`1499`	`1499`	`WithType(DefaultStream),`
`1500`	`1500`	`WithSchemaDescriptor(testTable.dp),`
	`1501`	`+ EnableWriteRetries(true),`
`1501`	`1502`	`)`
`1502`	`1503`	`if err != nil {`
`1503`	`1504`	`t.Fatalf("NewManagedStream %d: %v", k, err)`