fix(storage): disable allow non-default credentials flag (#11337)

frankyn · web-flow · commit 145ddf4f6123 · 2024-12-20T15:52:17.000-08:00
* fix(storage): disable allow non-default credentials flag

* skip test for direct connectivity
diff --git a/storage/grpc_client.go b/storage/grpc_client.go
@@ -105,8 +105,7 @@ func defaultGRPCOptions() []option.ClientOption {
 		// Only enable DirectPath when the emulator is not being targeted.
 		defaults = append(defaults,
 			internaloption.EnableDirectPath(true),
-			internaloption.EnableDirectPathXds(),
-			internaloption.AllowNonDefaultServiceAccount(true))
+			internaloption.EnableDirectPathXds())
 	}
 
 	return defaults
diff --git a/storage/integration_test.go b/storage/integration_test.go
@@ -343,6 +343,7 @@ var readCases = []readCase{
 // 3. DC not detected with dual region bucket in EUR4
 // 4. DC not detected with regional bucket in EUROPE-WEST1
 func TestIntegration_DetectDirectConnectivityInGCE(t *testing.T) {
+	t.Skip("Does not work in kokoro yet")
 	ctx := skipHTTP("grpc only test")
 	multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, bucket string, prefix string, client *Client) {
 		h := testHelper{t}

Original file line number	Diff line number	Diff line change
`@@ -105,8 +105,7 @@ func defaultGRPCOptions() []option.ClientOption {`
`105`	`105`	`// Only enable DirectPath when the emulator is not being targeted.`
`106`	`106`	`defaults = append(defaults,`
`107`	`107`	`internaloption.EnableDirectPath(true),`
`108`		`- internaloption.EnableDirectPathXds(),`
`109`		`- internaloption.AllowNonDefaultServiceAccount(true))`
	`108`	`+ internaloption.EnableDirectPathXds())`
`110`	`109`	`}`
`111`	`110`
`112`	`111`	`return defaults`